No refetchObservableQueries - #293
Open
PowerKiKi wants to merge 2 commits into
Open
Conversation
…)` #12584
The most common use case for `modelService.delete()` is from a page
detail, and after deletion the user is redirected to the page listing.
So there is no need to `refetchObservableQueries()` unconditionally.
# Other use cases
For other use cases we can reload specific queries like those
examples.
## Dialog
From a dialog on top of the listing page:
```ts
this.itemService
.delete([id], {
// Wait till we refresh the list under the dialog before closing the dialog, to avoid re-clicking on the just deleted item
refetchQueries: [itemsQuery],
awaitRefetchQueries: true,
})
.subscribe({
next: () => {
this.alertService.info(`Supprimé`);
this.dialogRef.close();
}
});
```
## Inline deletion in listing
From a listing page where deletion is directly accessible on the row:
```ts
this.itemService.delete([id], {
refetchQueries: [itemsQuery],
}).subscribe({
next: () => {
this.alertService.info(`Supprimé`);
},
error: () => this.deleting.delete(id),
});
```
## Bulk deleting
Bulk deleting via `NaturalAbstractList.bulkDelete()` still automatically
refetch the listing of items, but no other queries anymore.
…)` #12584
The most common use case for `modelService.create()` is from a page
detail for creation, and after the creation the user is redirected
to the page detail for edition. So there is no need to
`refetchObservableQueries()` unconditionally.
# Other use cases
For other use cases we can reload specific queries like those
examples.
## Dialog
From a dialog on top of the listing page:
```ts
this.itemService
.create({...}, {
// Refresh the list under the dialog
refetchQueries: [itemsQuery]
})
.subscribe(newItem => {
this.alertService.info('Créé');
this.dialogRef.close(newItem);
});
```
## Inline creation in listing
From a listing page where row creation is inline, there is nothing to do,
because the row already exists before we even mutate the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most common use case for
modelService.delete()is from a page detail, and after deletion the user is redirected to the page listing. So there is no need torefetchObservableQueries()unconditionally.Other use cases
For other use cases we can reload specific queries like those examples.
Dialog
From a dialog on top of the listing page:
Inline deletion in listing
From a listing page where deletion is directly accessible on the row:
Bulk deleting
Bulk deleting via
NaturalAbstractList.bulkDelete()still automatically refetch the listing of items, but no other queries anymore.