Skip to content

fix(log): mask secret values in logged info tables #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrrobot47 merged 2 commits into from
Oct 12, 2026
+16 −3
Merged

fix(log): mask secret values in logged info tables #1947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ddf65
fix(log): mask the secret rows of info tables in logged output
mrrobot47 Oct 12, 2026
db14274
fix(log): match the secret keyword as a whole word of the table label
mrrobot47 Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions php/utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,15 +1562,28 @@ function mask_secret_argv( $argv ) {

/**
* Last-resort masking for secrets EE has no value for, such as another host's site details or a value shorter than
* `EE::obfuscate()` accepts: `--<secret>=value` flags, `"<secret>": value` JSON members, mysql `-p<password>` and
* openssl `pass:<password>`.
* `EE::obfuscate()` accepts: `--<secret>=value` flags, `"<secret>": value` JSON members, mysql `-p<password>`,
* openssl `pass:<password>` and the value cell of a `| DB Password | value |` table row.
*
* @param string $text Text to be logged.
*
* @return string
*/
function mask_secret_patterns( $text ) {
if ( ! is_string( $text ) || ( false === strpos( $text, '-' ) && false === strpos( $text, '"' ) ) ) {
if ( ! is_string( $text ) ) {
return $text;
}
// A nested `ee site create` (clone) prints the new site's info table, whose values the parent process never saw.
// The keyword must be a whole word of the label, so rows like `Cache bypass` stay readable.
if ( false !== strpos( $text, '|' ) ) {
$table = preg_replace(
'/(\|[ \t]*+[^|\n]*?(?<![a-z])(?:pass(?:word|wd|phrase)?|pwd|secret|token|api[-_ ]?key)s?(?![a-z])[^|\n]*+\|[ \t]*+)[^|\s][^|\n]*?([ \t]*+\|)/i',
'$1******$2',
$text
);
$text = null === $table ? $text : $table;
}
if ( false === strpos( $text, '-' ) && false === strpos( $text, '"' ) ) {
return $text;
}

Expand Down
Loading