Repository navigation
v0.2.0: adjustments[], scenarios → scenario_results, attacker/angle graph axes, formats in main wasm (contract 1.5.0) - #6
Merged
Conversation
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Engine side of the EXFA v2 upgrade. Contract 1.5.0 / graphs contract 0.4.
1.
adjustments[]— every calc output now carries a top-leveladjustmentsarray (always present, right afterviolations) that records the silent normalisations introduced in 1.4.6:{"code":"STATE_CLAMPED","path":"/modules/1/state","from":"active","to":"online","message":"module state clamped to online"}Codes:
STATE_CLAMPED,FIGHTER_QUANTITY_CLAMPED,SLOT_OCCUPIED_SKIPPED,SECURITY_DEFAULTED,MODE_DEFAULTED(the oldno tactical mode given; defaulted…warning moves here). The four tiers are now: adjustments = input corrected and the calc continues; violations = can't be fitted in game; warnings = input the engine couldn't handle; error = the calc failed. Only the top-level fit reports adjustments.2.
scenarios[]→scenario_results[]— effective dps/volley against a fixed enemy + geometry (distance_m, target/attacker speed m/s or %,tgt_angle_deg,atk_angle_deg,tgt_sig_m,time_s).targetis the same object as GraphRequesttarget. Numbers come fromdmg::point_values, which the damage graph sweep also uses, so they match the graph at that point exactly. One difference in defaults:settings.ignore_resistsdefaults to false here. If a scenario is invalid, that entry gets{id, error}and the rest of the calc is unaffected.3. Graph axes —
damageandapplication_profileacceptatk_speed_mps,atk_speed_pct,atk_angle_deg,tgt_angle_deg.Ctx::param_freturns x for the active axis, so any param can be swept.4. Formats in
exfa_wasm— if corerpcreturnsUNKNOWN_METHOD, it falls back toexfa_formats::rpc_method, so the web app can load a single wasm.exfa_formats_wasmis still built and released unchanged. Size: 5.41 MB → 5.63 MB raw (gzip 1.76 → 1.84 MB). This replaces a second 0.69 MB gzip download and a second instantiation.Gates: version 0.2.0. Round-1 hashes regenerated after the rebuild, with
adjustmentsadded toci/round1-new-keys.txt. Native + wasm bench suites have no regressions (core 339/339, ext 239/239, ext_rpc 54/54, graphs 192/192, formats 4779/4779, …). New tests are intests/adjustments_scenarios.rs.Link to Devin session: https://app.devin.ai/sessions/af7bf1024e1246509c4bd4bf139c6702
Open in Devin Desktop: https://app.devin.ai/desktop/session/af7bf1024e1246509c4bd4bf139c6702?variant=devin
Requested by: @elwina