Repository navigation
v0.1.3: violations for drone/fighter bay, cargo and fighter tubes (contract 1.4.7) - #5
Merged
devin-ai-integration[bot] merged 2 commits intoOct 6, 2026
Conversation
…ntract 1.4.7) Resource-bar overloads Pyfa shows as red bars are now reported in violations[]: DRONE_BAY, FIGHTER_BAY, CARGO_OVERLOAD, FIGHTER_TUBES (total + light/support/heavy classes). Gate hashes updated for the intended output change. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…output) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate()now reports resource-bar overloads that Pyfa only shows as red bars: new violation codesDRONE_BAY(drones overdroneCapacity),FIGHTER_BAY(fighters overfighterCapacity),CARGO_OVERLOAD(cargo overcapacity), andFIGHTER_TUBES(squads overfighterTubestotal and per light/support/heavy class). Contract bumped to 1.4.7.compute_statsalready computes the used/total values forresources;validatereuses them via new parameters (bay,fbay,cargo,tubes[4]). Verified: Nidhoggur with 12 light-fighter squads now emitsFIGHTER_TUBES(12 > 4 total, 12 > 3 light) andFIGHTER_BAY(72000 > 70000 m³).round-1 sha gates updated — 27 cases intentionally emit the new codes (reproduced locally before updating).
Link to Devin session: https://app.devin.ai/sessions/af7bf1024e1246509c4bd4bf139c6702
Open in Devin Desktop: https://app.devin.ai/desktop/session/af7bf1024e1246509c4bd4bf139c6702?variant=devin
Requested by: @elwina