Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #2990 +/- ##
==========================================
- Coverage 81.29% 81.18% -0.12%
==========================================
Files 358 361 +3
Lines 88753 89019 +266
==========================================
+ Hits 72151 72269 +118
- Misses 16602 16750 +148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements identification of natural-date single-machine scheduling subproblems and derives valid inequalities. See the description of
highs/mip/HighsMachineSchedSeparator.hfor the exact description.Motivation: The instance
neos-3046615-murgfrom MIPLIB 2017 benchmark now solves well within time limit, andneos-3046601-motufrom MIPLIB 2017 collection now solves in a second or two (both were previously unsolvable within a few hours). This change should introduce some tinyepsilonand very positively affect some instances.Changes:
highs/mip/HighsMachineSchedSeparator.handhighs/mip/HighsMachineSchedSeparator.cpp. Currently the separator is only called once, and the cuts are only added to the pool. This is efficient, and I noticed no real change by trying to separate more frequently.Potential improvements that I don't think need to be made:
[-inf, 0]instead of[0, inf]. I'd currently not spot these. I'd also not spot a row where both binary columns share the same coefficient value (different signs), although I think presolve is going to scale these rows most of the time already.HighsCliqueTable, which I don't think was efficient to use in this case (could be wrong). There's likely going to be some instances that this code could improve but fails to because of this naive approach, however it ensures near-zero overhead is added to all other instances. An example: I suspectsupportcase26could be improved with some better detection.This should not be merged until a more thorough performance check has been made! @fwesselm This is a way lower priority than the MIP Worker Refactor to review / test.