[Bug] Unable to parse BYML that include recursive nodes

[Antonio225t]

First off I wanted to say that this is a very good library for handling BYML files but there's an issue that this resource explains:

Note: a BYAML file may contain cycles. This means that an array or dictionary may contain a node that the parser has seen earlier. Because of this, parsers must be careful not to end up in an infinite loop.

Sadly this library does not take into account this and crashes with a stack overflow error when trying to open EnterCatMarioStageMap.byml in Super Mario 3D World + Bowser's Fury...

This is the stack trace:

[... a lot more]
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlMap.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlMap.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlArray.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlMap.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlMap.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlArray.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlMap.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlMap.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlArray.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Nodes.Immutable.Containers.ImmutableBymlMap.ToMutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromImmutable(Revrs.RevrsReader, BymlLibrary.ImmutableByml ByRef, BymlLibrary.ImmutableByml ByRef)
   at BymlLibrary.Byml.FromBinary(System.Span`1<Byte>, Revrs.Endianness ByRef, UInt16 ByRef)
   at BymlLibrary.Byml.FromBinary(System.Span`1<Byte>)

I hope this gets fixed!
Also, this is unrelated but I'd like to know why this library does not support BYML V1

[ArchLeaders]

Thanks, I'll look into it when I get a chance.

As for the lack of v1 support, it probably works, but I've never seen a v1 file to test or verify this.

[Antonio225t]

Thanks for the reply! Super Mario 3D World + Bowser's Fury has some V1 BYMLs and by changing the version to 1 seems like it works but we need to further verify if it really works

[mjcox244]

Super Mario 3D world on Wii U uses V1 Byml

[Antonio225t]

Super Mario 3D world on Wii U uses V1 Byml

On Switch, 3DW (3D World) uses V1 for EnterCatMarioStageMap.byml in StageData/EnterCatMarioStage.szs and other files too, some use V2 some use V1