Fix: Prevent FriendsListToggle null reference after scene changes - #1297
Merged
Pong-Epic merged 9 commits intoJul 27, 2026
Conversation
JessTello
commented
Jun 11, 2026
JessTello
commented
Contributor
- Clear static Friends tab UI callbacks on scene unload to avoid retaining old listeners.
- Safely invoke Friends tab expand/collapse callbacks, skipping destroyed Unity targets.
- Guard optional UIFriendInteractionSource usage to prevent calls into missing or destroyed references during UI refresh.
- Clear static Friends tab UI callbacks on scene unload to avoid retaining old listeners. - Safely invoke Friends tab expand/collapse callbacks, skipping destroyed Unity targets. - Guard optional UIFriendInteractionSource usage to prevent calls into missing or destroyed references during UI refresh.
matt-clarke
requested changes
Jun 12, 2026
…friends-list-toggle-null-ref
matt-clarke
previously approved these changes
Jul 22, 2026
|
Finially fixed the add/remove listener in correct pair in OnEnable/OnDisable |
matt-clarke
reviewed
Jul 24, 2026
matt-clarke
previously approved these changes
Jul 24, 2026
ricardoamores-epic
approved these changes
Jul 27, 2026
matt-clarke
approved these changes
Jul 27, 2026
Pong-Epic
removed their request for review
July 27, 2026 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.