Skip to content

fix(dashboard): drop the details accordion from virtual model rows - #1079

Open
SantiagoDePolonia wants to merge 1 commit into
mainfrom
fix/dashboard-virtual-model-details
Open

SantiagoDePolonia wants to merge 1 commit into
mainfrom
fix/dashboard-virtual-model-details

Conversation

@SantiagoDePolonia

@SantiagoDePolonia SantiagoDePolonia commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Virtual model rows on Dashboard → Models showed the first resolvable target's details, which duplicates the target's own row and misdescribes virtual models that route to several targets (balanced/failover). Only real model rows now expand.

Summary by CodeRabbit

  • Bug Fixes
    • Virtual-model rows no longer display an accordion toggle; only rows for models with an ID can be expanded.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: aef676d5-4f58-4fa6-926d-3676f4859a88

📥 Commits

Reviewing files that changed from the base of the PR and between d6f8924 and 9cf31e4.

📒 Files selected for processing (2)
  • web/dashboard/src/pages/models/modelDetails.js
  • web/dashboard/tests/models-details.test.js

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

rowHasModelDetails now returns false for alias rows. The test expects false for an alias row with owned_by and empty metadata.

Changes

Model detail toggle

Layer / File(s) Summary
Toggle predicate and test
web/dashboard/src/pages/models/modelDetails.js, web/dashboard/tests/models-details.test.js
Alias rows no longer qualify for a toggle. The test now expects false for an alias row with owned_by and empty metadata.

Estimated code review effort: 2 (Simple) | ~7 minutes

Merge Risk: ⚪ Minimal · up to 9cf31

Virtual model rows no longer show potentially misleading target details. No actionable merge risk is evident from the supplied change.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing the details accordion from virtual model rows.
Description check ✅ Passed The description explains what changed and why. It identifies the affected Dashboard view, the incorrect behavior, and the corrected behavior. The optional AI Generated section is not required.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the model row,
No alias toggle shows below.
Real IDs keep their detail way,
The test confirms the change today.
Then off through clover, quick and light,
With tidy rows in dashboard sight.

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

Safe to merge: no blocking or non-blocking issues were found.

What we checked:

  • Prepared the dashboard dependencies and generated required message files for the rowHasModelDetails validation. T-Rex
  • Ran the rowHasModelDetails check using a virtual row with a resolved target ID, owner, and metadata, exercising the validation path for non-real rows (returned false). T-Rex
  • Ran the rowHasModelDetails check using a real row containing an ID, exercising the validation path for real rows (returned true). T-Rex

Reviews (1) · Last reviewed commit: "fix(dashboard): drop the details accordi..."

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants