Repository navigation
chore(kms): rename auth-eth-bun to auth-eth - #1550
Merged
Merged
Conversation
kvinwang
force-pushed
the
chore/remove-auth-eth-server
branch
from
November 9, 2026 16:46
73d7fd0 to
5bea4f5
Compare
Signed-off-by: Kevin Wang <wy721@qq.com>
Base automatically changed from
chore/remove-auth-eth-server
to
feat/kms-epochs-combined
November 9, 2026 16:48
kvinwang
force-pushed
the
chore/rename-auth-eth-bun
branch
from
November 9, 2026 16:49
580a631 to
aded7ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the Node server gone (#1549),
auth-eth-bunis the only on-chain webhook, so the-bunsuffix no longer distinguishes anything. Its contracts live separately indstack/kms/auth-eth.Fix
Move the Bun server (
index.ts, tests,package.json,bun.lock,Dockerfile,openapi.json, lint/vitest config) intodstack/kms/auth-ethwithgit mv. It now sits next to the Foundry project, the way the Node server did.dstack/kms/auth-eth-bunis removed.Merge the two READMEs into
dstack/kms/auth-eth/README.md.Rename the externally visible names:
auth-ethkms-auth-eth.yml/KMS auth-ethghcr.io/dstack-tee/dstack-kms-auth-ethkms-auth-eth-v*Images already published as
dstack-kms-auth-eth-bunstay available. The README and CHANGELOG say so.Keep the server tooling out of the Foundry files:
.oxlintrc.jsonignoreslib/,out/,cache/andbroadcast/. Lint covers 2 files instead of 498.*.test.tsat the top level..dockerignorestays an allowlist, so the build context is about 100 B and the image has nolib/orcontracts/.dstack/kms/auth-eth/*, top-level files only. Contract-only changes go tofoundry-test.ymland do not rebuild the image.foundry-test.yml: with a Bunpackage.jsonin the directory,npm install --no-save @openzeppelin/upgrades-coreresolves the server's dependency tree. npm 10.8.2 then crashes withCannot read properties of null (reading 'edgesOut'). The step now warms the npx cache withnpx --yes @openzeppelin/upgrades-core@^1.37.0, the same spec the upgrades library calls, so the tests reuse that install. CLAUDE.md and the README are updated to match.Updated docs, tutorials,
REUSE.toml,compose-dev.yamlanddstack/kms/README.md. Tutorials now copy onlyindex.ts,package.jsonandbun.lock, not the whole directory.Testing
bun install --frozen-lockfile && bun run check: 58/58 tests pass, the same count as before the move. Lint is clean andbun auditfinds no vulnerabilities.node_modules:forge fmt --check,forge build --sizes, the npx warm-up, thenforge clean && forge test --ffi. 100/100 pass. They also pass with Bun'snode_modulespresent.docker buildfromdstack/kms/auth-eth: the image has onlyindex.ts,package.jsonandnode_modules. It starts and serves against a local Anvil.reuse lintand prek (yaml/json/toml/whitespace) pass.