Skip to content

chore(kms): rename auth-eth-bun to auth-eth - #1550

Merged
kvinwang merged 1 commit into
feat/kms-epochs-combinedfrom
chore/rename-auth-eth-bun
Nov 9, 2026
Merged

kvinwang merged 1 commit into
feat/kms-epochs-combinedfrom
chore/rename-auth-eth-bun

Conversation

@kvinwang

@kvinwang kvinwang commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

With the Node server gone (#1549), auth-eth-bun is the only on-chain webhook, so the -bun suffix no longer distinguishes anything. Its contracts live separately in dstack/kms/auth-eth.

Fix

  • Move the Bun server (index.ts, tests, package.json, bun.lock, Dockerfile, openapi.json, lint/vitest config) into dstack/kms/auth-eth with git mv. It now sits next to the Foundry project, the way the Node server did. dstack/kms/auth-eth-bun is removed.

  • Merge the two READMEs into dstack/kms/auth-eth/README.md.

  • Rename the externally visible names:

    • package auth-eth
    • workflow kms-auth-eth.yml / KMS auth-eth
    • image ghcr.io/dstack-tee/dstack-kms-auth-eth
    • release tags kms-auth-eth-v*

    Images already published as dstack-kms-auth-eth-bun stay available. The README and CHANGELOG say so.

  • Keep the server tooling out of the Foundry files:

    • .oxlintrc.json ignores lib/, out/, cache/ and broadcast/. Lint covers 2 files instead of 498.
    • vitest only includes *.test.ts at the top level.
    • .dockerignore stays an allowlist, so the build context is about 100 B and the image has no lib/ or contracts/.
    • The workflow path filter is dstack/kms/auth-eth/*, top-level files only. Contract-only changes go to foundry-test.yml and do not rebuild the image.
  • foundry-test.yml: with a Bun package.json in the directory, npm install --no-save @openzeppelin/upgrades-core resolves the server's dependency tree. npm 10.8.2 then crashes with Cannot read properties of null (reading 'edgesOut'). The step now warms the npx cache with npx --yes @openzeppelin/upgrades-core@^1.37.0, the same spec the upgrades library calls, so the tests reuse that install. CLAUDE.md and the README are updated to match.

  • Updated docs, tutorials, REUSE.toml, compose-dev.yaml and dstack/kms/README.md. Tutorials now copy only index.ts, package.json and bun.lock, not the whole directory.

Testing

  • bun install --frozen-lockfile && bun run check: 58/58 tests pass, the same count as before the move. Lint is clean and bun audit finds no vulnerabilities.
  • Foundry, following the CI steps from a clean npm cache with no node_modules: forge fmt --check, forge build --sizes, the npx warm-up, then forge clean && forge test --ffi. 100/100 pass. They also pass with Bun's node_modules present.
  • docker build from dstack/kms/auth-eth: the image has only index.ts, package.json and node_modules. It starts and serves against a local Anvil.
  • reuse lint and prek (yaml/json/toml/whitespace) pass.

@kvinwang
kvinwang force-pushed the chore/remove-auth-eth-server branch from 73d7fd0 to 5bea4f5 Compare November 9, 2026 16:46
Signed-off-by: Kevin Wang <wy721@qq.com>
Base automatically changed from chore/remove-auth-eth-server to feat/kms-epochs-combined November 9, 2026 16:48
@kvinwang
kvinwang force-pushed the chore/rename-auth-eth-bun branch from 580a631 to aded7ab Compare November 9, 2026 16:49
@kvinwang
kvinwang merged commit bf19f4c into feat/kms-epochs-combined Nov 9, 2026
4 checks passed
@kvinwang
kvinwang deleted the chore/rename-auth-eth-bun branch November 9, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant