Conversation
pnpm precommit and pnpm lint fail on a clean checkout: the formatter wants the expectation array on one line. The wrapping came in with 081ec3c and no CI enforces the formatter, so every contributor starts from a red precommit. Output of biome format --write with the locked biome version; no semantic change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm precommit(andpnpm lint) fail on a clean checkout ofmain: biome's formatter wants the expectation array insrc/utils/redactSensitive.test.tson one line. The wrapping came in with 081ec3c, and since no CI enforces the formatter, every contributor currently starts from a red precommit.This is the output of
npx biome format --write src/utils/redactSensitive.test.tswith the biome version from the lockfile. No semantic change; tests stay 46/46.A small workflow running
pnpm precommitandpnpm teston pull requests would keep formatter drift from landing again. I can send that as a follow-up PR if you want it.