-
Notifications
You must be signed in to change notification settings - Fork 23
feat: support React 19 #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: support React 19 #1074
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0236698
refactor: drop findDOMNode and dead defaultProps
frankieyan b311778
feat: support React 19
frankieyan 0a43ff6
test: add React 18 jest run
frankieyan e01c8cf
ci: run tests against React 18 and 19
frankieyan e51708e
chore: remove prop-types usage
frankieyan 06f5c40
refactor: drop the ref-masking cast in polymorphicComponent
frankieyan a79132d
refactor: type ThreeDotsIcon's color prop
frankieyan e4a2f56
test: document the keyboard-driven submenu selection
frankieyan 17c8ba2
chore: type-check against React 18 typings
frankieyan f33bb87
fix: reject string refs in Tooltip
frankieyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| lint-staged.config.js | ||
| jest.config.js | ||
| jest.config.react18.js | ||
| babel.config.js | ||
| plopfile.mjs | ||
| release.config.js | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| const baseConfig = require('./jest.config') | ||
|
|
||
| // Runs the Jest suite against React 18 by remapping react/react-dom to the aliased 18 packages. | ||
| module.exports = { | ||
| ...baseConfig, | ||
| moduleNameMapper: { | ||
| ...baseConfig.moduleNameMapper, | ||
| '^react$': 'react-18', | ||
| '^react/(.*)$': 'react-18/$1', | ||
| '^react-dom$': 'react-dom-18', | ||
| '^react-dom/(.*)$': 'react-dom-18/$1', | ||
| }, | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.