update defaults behaviour - #65
Merged
Merged
Conversation
Adds a new function to return default dataset or group name ## hdfmap_class.py - Add *HdfMap.get_default_name()* - add test
## hdfmap_class.py - move *generate_alt_name()* into eval_functions.py - move Dataset and Group into objects.py
change *prepare_expression()* to use a dict of Dataset objects rather than the hdf file, so that prepare_expression can be used in HdfMap without opening the file. In practice, this doesn't work as a complete list of datasets needs to be built, testing each dataset in the list against the hdf file, which is much slower than the old way of only testing the identifiers that exist in the expression. Tests pass except test_compare_many_files, which shows a significant slow down. This commit will be reverted.
This reverts commit 410c0c9.
This new function is useful for debugging and returns the prepared expression and dict of data, prior to evaluation. ## hdfmap_class.py - add *HdfMap.generate_eval_expression()* - add test for this ## reloader_class.py - add *HdfLoader.generate_expression()* All tests pass.
Move HdfMap Interpreter from HdfMap class to reloader class. All tests pass.
## eval_functions.py - refactor *prepare_expression*, adding seperate functions for each replacement. ## hdfmap_class.py - add *HdfMap.merge_default_names* - add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new function to return default dataset or group name
eval_functions.py
hdfmap_class.py
reloader_class.py
Tests