Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
+ Coverage 95.25% 95.27% +0.01%
==========================================
Files 43 43
Lines 3164 3173 +9
==========================================
+ Hits 3014 3023 +9
Misses 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
reviewed
Apr 22, 2026
| LOGGER.info(f"Installing {path}") | ||
| process = Popen( | ||
| [ | ||
| if paths: |
Contributor
There was a problem hiding this comment.
nit: if not paths: return would stop the whole function being indented
|
|
||
| def scratch_install(path: Path, timeout: float = _DEFAULT_INSTALL_TIMEOUT) -> None: | ||
| def scratch_install( | ||
| paths: list[Path], timeout: float = _DEFAULT_INSTALL_TIMEOUT |
Contributor
There was a problem hiding this comment.
Suggested change
| paths: list[Path], timeout: float = _DEFAULT_INSTALL_TIMEOUT | |
| *paths: Path, timeout: float = _DEFAULT_INSTALL_TIMEOUT |
Would prevent the API changing for existing calls
| ) -> None: | ||
| """ | ||
| Install a scratch package. Make blueapi aware of a repository checked out in | ||
| Install all scratch package. Make blueapi aware of a repository checked out in |
Contributor
There was a problem hiding this comment.
Suggested change
| Install all scratch package. Make blueapi aware of a repository checked out in | |
| Install scratch packages. Make blueapi aware of repositories checked out in |
(and a couple more plural consistency changes in the doc string)
| remote_url, | ||
| local_directory, | ||
| branch=target_revision, | ||
| multi_options=["--filter=blob:none"], |
Contributor
There was a problem hiding this comment.
I think you can pass this as a keyword
Suggested change
| multi_options=["--filter=blob:none"], | |
| filter="blob:none", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1417