Repository navigation
Fix incorrect pagination of workflows - #258
Conversation
The code was taken from the workflows dashboard for how that project deals with the incorrect pagination behaviour of the graph-proxy (the workflows graphql service), see the following for where the code was copied from and modified slightly: - https://github.com/DiamondLightSource/workflows/blob/cd253acd7cf18b48cb1f9e061065f379bae8c538/frontend/relay-workflows-lib/lib/utils/useServerSidePagination.ts - https://github.com/DiamondLightSource/workflows/blob/cd253acd7cf18b48cb1f9e061065f379bae8c538/frontend/relay-workflows-lib/lib/components/WorkflowsContent.tsx#L44
|
@NatLeung96 I'm not necessarily expecting you to understand the new I think the displayed workflows is now correct when traversing across pages, but I've only tested it a bit, so having that be double-checked is also useful. |
|
Yeah, it's annoying that we have to implement something like this in the frontend when it should be fixed in the graph. |
NatLeung96
left a comment
NatLeung96
left a comment
There was a problem hiding this comment.
Looks good.
A side note for another ticket. Playing around around with the table, I noticed that the column widths keeps changing so they move around. It would be good if we can fix these.
The code was taken from the workflows dashboard for how that project deals with the incorrect pagination behaviour of the graph-proxy (the workflows graphql service), see the following for where the code was copied from and modified slightly: