Skip to content

add empty rows - #251

Merged
NatLeung96 merged 3 commits into
mainfrom
nl/add-empty-rows
Oct 29, 2026
Merged

NatLeung96 merged 3 commits into
mainfrom
nl/add-empty-rows

Conversation

@NatLeung96

Copy link
Copy Markdown
Collaborator

This PR adds empty rows to the WorkflowsTable so that the height doesn't fluctuate with the number of workflows.

There are some magic numbers in there which I am not too pleased with but I'm not sure if there is a better way.

@NatLeung96
NatLeung96 force-pushed the nl/add-empty-rows branch 2 times, most recently from 36de08b to 59da957 Compare October 28, 2026 11:03

@yousefmoazzam yousefmoazzam left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, the magic numbers isn't great, but it does the trick.

I'm content with this as a solution, so feel free to merge.

If you're interested, I think I found an alternative in #259 that uses hidden rows rather than magic numbers, out of curiosity more than anything if it would work. Feel free to use that, or use it as inspiration for some other hacking! 😆

@NatLeung96
NatLeung96 merged commit 5aa9d3b into main Oct 29, 2026
1 check passed
@NatLeung96
NatLeung96 deleted the nl/add-empty-rows branch October 29, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants