Repository navigation
Small fixes in the installer, the recovery tool, the hooks and CI's checks - #217
Merged
Merged
Conversation
…hecks - kryptik-install checks veritysetup and the coreutils it calls before the first write; without veritysetup it failed after partitioning with a misleading "does not verify". - kryptik-recover unmounts the medium and its ESP image too when it dies mid-restore, and checks root.json's fields for form as the installer does. - check-pin-reviews: --survey or --reviews given last no longer loops forever. - artifact-manifest: one RETURN trap that removes all four temporary files and then itself; the second trap had replaced the first and stayed set. - The pre-commit hook and CI's CRLF step find scripts by shebang as well, so tools/kryptik, kryptik-update, kryptik-recover and the run files are checked. - source-notes: the bc row described a shim 72ab0b0 removed. - install-test: a blkid nothing read; stage 05 takes the same RAM-capped job count as the other stages. - decisions.md: ADR-011 says why the cookies stay, and ADR-012 gives the root image's real size.
DevomB
added a commit
that referenced
this pull request
Oct 7, 2026
…json in kryptik-recover give way to medium_root, which makes the same checks and ties the record to the signed command line, and medium_root takes #217's rule that a record must name a version; the installer's tool list is main's with grep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes from the repository cleanup's bug list, each checked against main 91c3238.
veritysetupand the coreutils it calls (cut basename mv mountpoint rmdir chmod rm cat sleep) before the first write. Withoutveritysetupan install failed after partitioning and writing slot A, with a misleading "does not verify".--restore-slotthat died between mounting the medium and finishing left/run/kryptik-recover-mediaand the loop-mounted ESP image mounted; the exit trap now unmounts all three (the ESP image first, since it lives on the medium). It also checks root.json'stotal_bytes,sha256andversionfor form, as the installer does, so an empty field no longer reads as "slot is smaller than the medium's root image".--surveyor--reviewsgiven last madeshift 2fail without shifting, and the loop never ended. Both now need their value (${2:?...}), as the other tools' options do.emit_treeset a RETURN trap twice, so the second replaced the first (two temporary files leaked) and the trap stayed set after the function, firing on every later return. One trap now removes all four files and then itself.tools/kryptik,kryptik-update,kryptik-recover,kryptik-session,kryptik-chrome, the hooks and the s6 run files were never checked. Both now take a file whose first line is a shebang too; the hook'sbash -ntakes shell shebangs.fix-libmath_hshim that 72ab0b0 removed, so the inventory reported a caveat that no longer exists.blkidinside the label capture whose output nothing read. 05-kernel.sh: the RAM-cappedkryptik_default_jobslike every other stage (top-level code, so nothing rebuilds; the same 4 jobs on a runner).nosmtlets root turn it back on. ADR-012 said the root image is 2.7 GB; v0.1.0's root.json gives 1.66 GB with its hash tree.Left out:
wlprobe.ctrusts the string lengths in the compositor's messages (it is a test tool talking to a trusted compositor, and #191 and #201 both rewrite it).Conflicts to expect, all small: #176 (ci.yml), #199 (check-pin-reviews.sh, pre-commit, source-notes.tsv), #203 (kryptik-recover, artifact-manifest.sh), #206 and #210 (05-kernel.sh comments), #179 #180 #188 #207 (the installer, elsewhere in the file), the design PRs (decisions.md, at its end only).
The installer and kryptik-recover are on the medium, so this needs one Distro run.