Repository navigation
Acceptance jobs fetch the sources an evicted cache no longer holds - #216
Merged
Merged
Conversation
The acceptance parts took the upstream sources only from the Actions cache. A cache evicted in the hours between the build job and acceptance (tonight's branch runs push the 10 GB store past its limit) left sources-lock and kernel-config failing on files that were never missing from the build. A job that restores now fetches what the cache lacks, held to sources.lock like any fetch, and saves nothing; only 'fetch' jobs save the set and run the signature pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acceptance parts took the upstream sources only from the Actions cache (
preparewithsources: restore, exact key, no fallback). When that cache is evicted in the two hours or so between the build job and acceptance, the parts'sources-lockandkernel-configitems fail on files the build had all along. That is what turned #173's run red (36981993351: four parts whole, the fifth's VM suites all passed, only those two items failed with "Cache not found for input keys: sources-v3-8b6e5764…"). Tonight's many branch runs push the 10 GB cache store past its limit, and a tag's acceptance restores main's cache by the same key, so a release run could fail the same way.Now a job that restores also fetches what the cache lacks (
make sources, thenprune-sources.sh; every file is still hashed againstsources.lock), starting from the closest older set like afetchjob does. It saves nothing, so the five parts do not race to write the cache; onlyfetchjobs save the set and run the signature pass.Conflict to expect: #176 (cleanup-ci) shortens comments in the same file.
Not exercised by a Distro run: a branch run restores main's cache by its exact key, so the new step would not run. It is the same two commands the build job runs on a miss.