Repository navigation
Shorten compositor comments and test names - #186
Merged
Merged
Conversation
DevomB
force-pushed
the
cleanup-compositor
branch
3 times, most recently
from
October 2, 2026 09:09
2a88ef7 to
203b255
Compare
Comment stacks in kryptik-wlproxy and zoneid become one line, or a two-line block where the reason needs it, and long test names are cut to a few words. Code changes: the wlproxy session tests share two setup helpers, and zoneid's error and audit messages lose their essays. The generated protocol tables and zone-colours.h are unchanged.
DevomB
force-pushed
the
cleanup-compositor
branch
from
October 2, 2026 09:09
203b255 to
a1d9ad4
Compare
DevomB
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup for
compositor/(kryptik-wlproxy and zoneid) and the comments oftools/desktop/gen-wl-protocol.py./* */block where the reason needs it. Narration, history ("now", "yet") and rhetoric go.shm_pool_creation_and_resize_have_byte_and_count_limits->shm_pool_limits. No script or CI step names a test.with_toplevel()andwith_shm(); awire/tests.rsassertion drops a filter that always gaveSome(s)./// The proxied connection.sat onstruct Pool.Unchanged on purpose: the generated
protocol_tables.rsand whatgen-wl-protocol.pyemits, and every message a test or guest check greps.The rest of
tools/desktop/andbuild/desktop/dwl-config.hare left out: open pull requests #184, #188 and #191 change them. Their cleanup follows once those land.Build cost: kryptik-wlproxy's binary changes, so the late
desktopstep of stage 04 rebuilds; nothing earlier.