Repository navigation
The signatures are kept in the sources cache - #169
Merged
Merged
Conversation
…so the gate reads them from disk instead of asking every host on every run; a signature file that comes back as something else is asked for once more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature gate fetched each source's detached signature from its upstream on every run, because the sources cache is saved before the gate runs and so never held them. Six times in two days one host or another answered a runner with a 418, a 500 or a page in place of the file (lynx's mirror twice), and the gate went red with nothing changed. Now the step that fills the cache also runs the verifier once, output discarded, so the signatures land in /.signatures before the save, in CI and in the Distro jobs' prepare action alike; the gate then reads them from disk. The cache key goes to v3 so the next run on main fills a cache that holds them. verify_detached also asks once more when what came back is not an OpenPGP signature, before calling the source unverifiable.