Repository navigation
The launcher suite waits up to 30 s for a stopped zone's volume to close - #163
Merged
Merged
Conversation
… not 10: the launcher closes it after pid 1 is gone, and a slow runner once took longer, which failed destroy for a volume that was merely still closing; the failure now says what stop answered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On main's run for 07e7666 the host-suites item failed in launcher.sh at F6b and F6c: after
kryptikd stop sealed --now, the suite waited 10 s for the LUKS mapping to go and then ranvolume destroy, which was refused because the volume was still open. The launcher closes the volume once the zone's pid 1 is gone, not beforestopreturns, and on that runner it took longer than 10 s; F4c, which checks the same mechanism, passed seconds earlier, and the same content passed whole on the branch run. F4c and F6b now wait up to 30 s (they stop waiting the moment the volume closes), and F6b's failure message includes whatstopanswered, so a real failure is told apart from a slow close.