Repository navigation
An incomplete keyring import is fetched again, not marked complete - #160
Merged
Merged
Conversation
…ring and every pinned key are in it: what a run could not fetch, the next fetches again, instead of nine keys being marked complete and 31 signed sources called unverifiable; --strict then says the keyring is incomplete
…rver does not serve (Torvalds' mainline key, which no pinned source uses) is fetched again next run, and the sources it signs stay unverifiable until then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On main's CI the inventory step fetched the GNU keyring and failed, imported the nine pinned maintainer keys, and wrote the imported mark with that count; the strict gate then reused the partial keyring and reported 31 signed sources unverifiable. Now the mark is written only when the GNU keyring is in the keyring (its own mark, after an import that yielded at least a hundred keys) and every pinned fingerprint is present; otherwise the mark is removed, the warning names what is missing, and the next invocation fetches only what is still missing.
--stricton an incomplete keyring fails with that diagnosis instead of a list of unverifiable sources.--refreshalso drops the GNU keyring's import mark.