Repository navigation
groff 1.24.2 reviewed: the image installs none of the programs it fixes - #159
Merged
Merged
Conversation
…off and pdfmom, does not reach an image that installs none of them, which the recipe now removes along with the HTML devices; man renders for a terminal, never HTML
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
groff 1.24.2 fixes command injection (CWE-78) in mmroff, pdfmom and pre-grohtml, the last of which runs for
-T html/-T xhtml. Kryptik's groff renders man pages for a terminal; nothing renders HTML. The pin stays at 1.23.0 (1.24.0's request-syntax changes are still not wanted), and the fix is kept from reaching the image at all: a groff recipe removes pre-grohtml, post-grohtml, mmroff, pdfmom, the html/xhtml devices and their man pages, in the recipe itself so a resumed sysroot loses them too. The review row is extended to 1.24.2, which makes the pin gate green again on main and passes--no-heldfor a tag.