Repository navigation
The signature gate asks a throttling host again, and a note is not stale when its signature could not be fetched - #158
Merged
Merged
Conversation
…ers 418 to a busy runner, others 429 or 503) and a 404 once, and a signature the run could not fetch leaves its no-usable-key note untried, not stale: a transient refusal is one unverifiable source, not two failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On #156 the Source manifest job failed with nothing changed under it: freedesktop.org answered HTTP 418 to the runner's fetch of libevdev's
.sig, soverify-signatures.sh --strictcounted libevdev unverifiable (correct: a signature it could not check) and then also called itsno-usable-keynote stale, because the note was never tried. Two failures for one throttled request, and a re-run was the only cure.quiet_fetchtries again after a pause on 418, 429 and 503 (three tries, 5 s then 10 s apart); a 404 or a missing file is an answer and is not retried, so sources that publish nothing stay quick..sigthat cannot be fetched, with a note, fails--strictas unverifiable and is not called stale.