Repository navigation
Fix the swapped package counts in the page subtitle and make the numbers stand out - #5534
Open
Maxime Landry (mlandry-devolutions) wants to merge 2 commits into
Open
Maxime Landry (mlandry-devolutions) wants to merge 2 commits into
Maxime Landry (mlandry-devolutions) wants to merge 2 commits into
Conversation
…tle and drew its numbers stronger than the words Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Maxime Landry (mlandry-devolutions)
requested review from
Gabriel Dufresne (GabrielDuf)
and
a balanced review from Copilot
October 16, 2026 18:56
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Numeric plural formatting breaks in several languages, and five translations retain incompatible count placeholders.
2 open findings
What changed in this PR
Corrects package-page subtitle counts and makes numbers more prominent while preserving a single accessible sentence.
Changes:
- Corrects total and filtered count argument order.
- Adds semibold count segments with secondary-colour supporting text.
- Provides combined subtitle text for accessibility.
| File | Description |
|---|---|
| src/UniGetUI.Avalonia/Views/SoftwarePages/AbstractPackagesPage.axaml.cs | Renders styled subtitle segments and sets the accessible name. |
| src/UniGetUI.Avalonia/Views/SoftwarePages/AbstractPackagesPage.axaml | Updates subtitle styling and list help-text binding. |
| src/UniGetUI.Avalonia/ViewModels/SoftwarePages/PackagesPageViewModel.cs | Corrects count order and separates subtitle segments, details, and accessible text. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ing, and swapped the placeholders in the five translations that compensated for the old order Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The package page subtitle passed its numbers in the wrong order: with 40 packages and a search that keeps 2, it read "2 packages were found, 40 of which match the specified filters." Once the Filters pane is collapsed it is the only sign that a filter is active, on every package page and in every language.
{0}is now everything the managers returned and{1}what the filters keep, as the sentence reads.TextFillColorSecondaryBrushinstead of a 0.6 opacity on the whole line. The translated sentence still decides where the numbers go: each value is wrapped in private-use marks before formatting, and the subtitle is split on them into runs. German, for instance, puts them mid-sentence.SubtitleAccessibleText, also used by the list's help text).No new string. Tested locally in several languages; rendered in English, French and German, light and dark.
Relates to UNI-38
🤖 Generated with Claude Code