Skip to content

Fix the swapped package counts in the page subtitle and make the numbers stand out - #5534

Open
Maxime Landry (mlandry-devolutions) wants to merge 2 commits into
mainfrom
fix/package-count-subtitle-order
Open

Maxime Landry (mlandry-devolutions) wants to merge 2 commits into
mainfrom
fix/package-count-subtitle-order

Conversation

@mlandry-devolutions

@mlandry-devolutions Maxime Landry (mlandry-devolutions) commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor
  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • Have you confirmed that this issue is caused by UniGetUI itself, and not by the package manager or the package involved?

The package page subtitle passed its numbers in the wrong order: with 40 packages and a search that keeps 2, it read "2 packages were found, 40 of which match the specified filters." Once the Filters pane is collapsed it is the only sign that a filter is active, on every package page and in every language.

  • Order: {0} is now everything the managers returned and {1} what the filters keep, as the sentence reads.
  • Numbers first: the found, matching and selected counts are drawn in semibold in the body text colour; the words and "(Last checked: …)" use TextFillColorSecondaryBrush instead of a 0.6 opacity on the whole line. The translated sentence still decides where the numbers go: each value is wrapped in private-use marks before formatting, and the subtitle is split on them into runs. German, for instance, puts them mid-sentence.
  • Accessibility: screen readers get the whole subtitle as one sentence (SubtitleAccessibleText, also used by the list's help text).
  • A page suffix (the catalog editor's "Unsaved changes") stays at the end of the line.

No new string. Tested locally in several languages; rendered in English, French and German, light and dark.


Relates to UNI-38

🤖 Generated with Claude Code

…tle and drew its numbers stronger than the words

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Numeric plural formatting breaks in several languages, and five translations retain incompatible count placeholders.

2 open findings
What changed in this PR

Corrects package-page subtitle counts and makes numbers more prominent while preserving a single accessible sentence.

Changes:

  • Corrects total and filtered count argument order.
  • Adds semibold count segments with secondary-colour supporting text.
  • Provides combined subtitle text for accessibility.
File Description
src/​UniGetUI.Avalonia/​Views/​SoftwarePages/​AbstractPackagesPage.axaml.cs Renders styled subtitle segments and sets the accessible name.
src/​UniGetUI.Avalonia/​Views/​SoftwarePages/​AbstractPackagesPage.axaml Updates subtitle styling and list help-text binding.
src/​UniGetUI.Avalonia/​ViewModels/​SoftwarePages/​PackagesPageViewModel.cs Corrects count order and separates subtitle segments, details, and accessible text.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/UniGetUI.Avalonia/ViewModels/SoftwarePages/PackagesPageViewModel.cs Outdated
Comment thread src/UniGetUI.Avalonia/ViewModels/SoftwarePages/PackagesPageViewModel.cs Outdated
…ing, and swapped the placeholders in the five translations that compensated for the old order

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants