Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the same issue can be reproduced outside UniGetUI with the relevant package manager or with the package itself, please report it there first. UniGetUI should only be used to track issues that are specific to UniGetUI's behavior or integration.
Thanks to piknockyou for the report.
Bun.GetGlobalPackagesDirectoryalways returned~/.bun/install/global. Bun itself picks the global directory fromBUN_INSTALL_GLOBAL_DIRfirst, then$BUN_INSTALL/install/global, then~/.bun/install/global(open_global_dirin oven-sh/bun,src/install/PackageManager/PackageManagerOptions.rs). With Bun installed through Scoop (BUN_INSTALLset to a persist folder), UniGetUI looked in a directory that does not exist, so installed packages and updates were never listed.The existing method now delegates to a new overload that takes an environment lookup and applies the same precedence; empty values are ignored. With no variables set the result is unchanged. The overload keeps the lookup injectable for tests, and
BunPkgDetailsHelperpicks up the fix through the existing call.Added
BunManagerTests.GetGlobalPackagesDirectoryHonorsBunEnvironmentVariables, coveringBUN_INSTALL_GLOBAL_DIR,BUN_INSTALL, neither set, and empty values. It fails when the environment variables are ignored.Testing:
dotnet test src/UniGetUI.PackageEngine.Tests/UniGetUI.PackageEngine.Tests.csproj --filter FullyQualifiedName~BunManagerTests(net10.0, Linux): 37 passed, 0 failed. Only this filter was run, not the full suite.dotnet format whitespaceon both changed files left them unchanged.dotnet format stylewas not run.Not covered here: Bun's
install.globalDirbunfig key,XDG_CACHE_HOMEfor the final fallback, and~/expansion inBUN_INSTALL_GLOBAL_DIR.Closes #4918