feat(activex): present EGFX dirty regions - #1874
Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 6 commits into
Open
feat(activex): present EGFX dirty regions#1874Marc-André Moreau (mamoreau-devolutions) wants to merge 6 commits into
Marc-André Moreau (mamoreau-devolutions) wants to merge 6 commits into
Conversation
Marc-André Moreau (mamoreau-devolutions)
temporarily deployed
to
llm-providers
September 1, 2026 18:37 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
September 1, 2026 18:37
View session
github-actions
Bot
added
kind/protocol
Contributor
There was a problem hiding this comment.
Pull request overview
Adds dirty-region delivery for ActiveX while retaining full-frame fallback.
Changes:
- Propagates validated EGFX reset extents into session framebuffers.
- Adds packed desktop updates and retained partial-frame presentation.
- Introduces bounded damage queuing and related tests/documentation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
crates/ironrdp-testsuite-extra/tests/client/output_channel.rs |
Tests desktop-update validation. |
crates/ironrdp-session/src/active_stage.rs |
Resizes framebuffers after EGFX resets. |
crates/ironrdp-egfx/src/compositor.rs |
Validates output dimensions and memory limits. |
crates/ironrdp-egfx/src/client.rs |
Reports validated reset extents. |
crates/ironrdp-client/src/rdp.rs |
Adds packed dirty-region delivery. |
crates/ironrdp-activex/src/rpc.rs |
Applies partial updates to retained RPC frames. |
crates/ironrdp-activex/src/control.rs |
Queues, merges, presents, and invalidates dirty regions. |
crates/ironrdp-activex/README.md |
Documents the dirty-region pipeline. |
Marc-André Moreau (mamoreau-devolutions)
temporarily deployed
to
llm-providers
September 1, 2026 18:54 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
breaking-change
Contributor
|
This pull request is Please split it into focused pull requests that can each be reviewed on their own. When the parts build on each other, stacked pull requests let you open each one on top of the last without waiting for the one below to merge. Stacks require every branch to live in this repository, so from a fork, please open separate pull requests instead. Automated review resumes once the change is below the |
Contributor
Author
|
The Note Human-tuned, LLM-assisted content. |
Marc-André Moreau (mamoreau-devolutions)
force-pushed
the
copilot/activex-accelerated-graphics
branch
from
September 2, 2026 15:15
18e915a to
36a08cb
Compare
Propagate validated ResetGraphics extents into the session framebuffer and deliver packed desktop damage to ActiveX without rebuilding full image snapshots. Coalesce only fully covered regions, preserve disjoint updates with bounded backpressure, and update retained GDI and RPC surfaces in place. Keep V8 non-AVC negotiation and full-frame output fallback unchanged.
Destroy prior surfaces when a ResetGraphics output exceeds local allocation limits, matching protocol reset semantics. Notify handlers about the rejected output so capture replay retains its unsupported-path classification and fuzz models stay synchronized.
Preserve exact compositor regions so sparse updates do not expand into full bounding-box copies, and cap queued pixel payloads at 256 MiB with backpressure. Retain software cursor shape, position, and visibility when ResetGraphics replaces the session framebuffer.
Invalidate retained RPC frames when a resized desktop exceeds the screenshot budget, and consume the EGFX client's accepted reset state directly during capture replay.
Keep exact frame and static-channel updates ordered when the UI queue is saturated, and make dispatch recovery fail instead of waiting without an outstanding message. Reuse framebuffer storage across graphics resets and clip retained software cursors without source-rectangle underflow.
Integrate partial frame presentation with the modern screen-update suspension contract by snapshotting one bounded full-frame base and applying every suspended dirty region before resume.
Marc-André Moreau (mamoreau-devolutions)
force-pushed
the
copilot/activex-accelerated-graphics
branch
from
September 2, 2026 19:35
36a08cb to
4091362
Compare
Marc-André Moreau (mamoreau-devolutions)
requested a balanced review from Copilot
September 2, 2026 20:50
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
September 2, 2026 20:50
View session
Benoît Cortier (CBenoit)
added
the
ai-review/allow-oversized
Benoît Cortier (CBenoit)
deployed
to
llm-providers
September 2, 2026 20:52 — with
GitHub Actions
Active
GitHub Actions
Active
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Direct frame dispatch can violate lifecycle ordering, and differing framebuffer extents still evict accepted updates.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Balanced
Comment on lines
+12030
to
+12035
| let client = RdpClient::new(config, output_sender).with_desktop_update_handler(move |update| { | ||
| let _ = queue_worker_event( | ||
| &desktop_update_events, | ||
| &desktop_update_posted, | ||
| HWND(desktop_update_hwnd as *mut c_void), | ||
| WorkerEvent::Image { |
Comment on lines
+17007
to
+17009
| if !same_extent { | ||
| queue[index] = event; | ||
| true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate validated ResetGraphics extents into the session framebuffer and deliver exact packed desktop damage to ActiveX without rebuilding full image snapshots.
Coalesce only fully covered regions, preserve sparse updates with a 64-event and 256 MiB pixel-data budget, and backpressure without evicting accepted frame or static-channel payloads. Update retained GDI and RPC surfaces in place. Reuse framebuffer storage with fallible growth, and retain software cursor shape, position, visibility, and clipping across graphics resets. Keep V8 non-AVC negotiation and full-frame output fallback unchanged. Rejected oversized resets still destroy prior surfaces and are reported as unsupported without allocating a session framebuffer.