fix(tls): select native TLS for Windows gateways - #1849
Draft
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Draft
fix(tls): select native TLS for Windows gateways#1849Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Conversation
Use native TLS for Windows RDP sessions and gateway forwards. Keep Rustls on non-Windows targets and validate exclusive resolution.
Marc-André Moreau (mamoreau-devolutions)
temporarily deployed
to
llm-providers
August 30, 2026 11:49 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
August 30, 2026 11:49
View session
github-actions
Bot
added
maintainer-required
Contributor
There was a problem hiding this comment.
Pull request overview
Selects native TLS on Windows and Rustls elsewhere for RDP and gateway paths.
Changes:
- Adds target-specific TLS backend dependencies.
- Adjusts TLS tests for platform capabilities.
- Validates backend exclusivity and documents behavior.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
xtask/src/check.rs |
Validates target TLS feature graphs. |
crates/ironrdp-viewer/Cargo.toml |
Selects viewer TLS by target. |
crates/ironrdp-tls/tests/native_tls.rs |
Adjusts lint handling. |
crates/ironrdp-testsuite-extra/tests/e2e.rs |
Adapts callback tests for native TLS. |
crates/ironrdp-testsuite-extra/Cargo.toml |
Selects test backend by target. |
crates/ironrdp-daemon/Cargo.toml |
Selects client TLS by target. |
crates/ironrdp-agent/README.md |
Documents platform backend behavior. |
crates/ironrdp-agent/Cargo.toml |
Selects gateway TLS by target. |
crates/ironrdp-activex/Cargo.toml |
Switches ActiveX to native TLS. |
| [features] | ||
| default = ["rustls"] | ||
| # The target-specific dependencies below choose the default TLS backend. | ||
| default = [] |
| [target.'cfg(windows)'.dependencies] | ||
| anyhow = "1" | ||
| ironrdp-client = { path = "../ironrdp-client", version = "0.1", features = ["clipboard", "dvc-com-plugin", "gateway", "location", "rdpdr", "rustls", "smartcard", "sound", "webauthn"] } | ||
| ironrdp-client = { path = "../ironrdp-client", version = "0.1", features = ["clipboard", "dvc-com-plugin", "gateway", "location", "native-tls", "rdpdr", "smartcard", "sound", "webauthn"] } |
Marc-André Moreau (mamoreau-devolutions)
marked this pull request as draft
August 30, 2026 11:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use native TLS for Windows RDP sessions and gateway forwards.
Keep Rustls on non-Windows targets and validate exclusive resolution.