feat(mstsgu): authenticate gateway sessions - #1802
Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 3 commits into
Open
feat(mstsgu): authenticate gateway sessions#1802Marc-André Moreau (mamoreau-devolutions) wants to merge 3 commits into
Marc-André Moreau (mamoreau-devolutions) wants to merge 3 commits into
Conversation
Negotiate MS-TSGU SSPI NTLM authentication and reauthenticate the original session on a short-lived transport without interrupting application data. Reject unsupported smart-card and pluggable exchanges explicitly.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 26, 2026 00:40 — with 
GitHub Actions
Active
GitHub Actions
Active
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
August 26, 2026 00:40
View session
Apply repository rustfmt output to gateway authentication changes.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 26, 2026 00:42 — with
GitHub Actions
Active
GitHub Actions
Active
github-actions
Bot
added
maintainer-required
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MS-TSGU extended NTLM authentication and background session reauthentication while retaining the primary data transport.
Changes:
- Negotiates and performs
SSPI_NTLMextended authentication. - Handles reauthentication on a secondary transport.
- Adds protocol tests and updates documentation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
crates/ironrdp-mstsgu/README.md |
Documents authentication and reauthentication support. |
crates/ironrdp-mstsgu/src/http_auth.rs |
Exposes NTLM extended-authentication steps. |
crates/ironrdp-mstsgu/src/lib.rs |
Implements authentication negotiation and reauthentication. |
crates/ironrdp-mstsgu/src/packet_io.rs |
Tracks and reuses negotiated authentication. |
crates/ironrdp-mstsgu/src/proto.rs |
Enables extended-authentication packet usage. |
crates/ironrdp-mstsgu/src/test_support.rs |
Adds authenticated and reauthentication test helpers. |
crates/ironrdp-mstsgu/tests/consent.rs |
Tests NTLM negotiation and reauthentication flows. |
Advertise reauthentication support and keep the active data path alive when secondary setup fails. Reject background consent when a caller supplied a borrowed callback.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 26, 2026 01:21 — with
GitHub Actions
Active
GitHub Actions
Active
github-actions
Bot
added
size/XL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negotiate MS-TSGU SSPI NTLM authentication and reauthenticate the
original session on a short-lived transport without interrupting
application data.
Reject unsupported smart-card and pluggable exchanges explicitly.