Skip to content

test(extra): centralize remaining integration tests - #1748

Open
Benoît Cortier (CBenoit) wants to merge 48 commits into
cbenoit-consolidate-replay-testsfrom
cbenoit-centralize-tls-rdpdr-tests
Open

test(extra): centralize remaining integration tests#1748
Benoît Cortier (CBenoit) wants to merge 48 commits into
cbenoit-consolidate-replay-testsfrom
cbenoit-centralize-tls-rdpdr-tests

Conversation

@CBenoit

@CBenoit Benoît Cortier (CBenoit) commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Move native TLS certificate-policy and Windows RDPDR filesystem coverage into the extra testsuite's sole integration harness. Product crates no longer expose standalone Cargo test targets. Update xtask's native TLS checks to exercise the centralized harness.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

@github-actions github-actions Bot added maintainer-required Maintainer review or intervention is required risk/low Self-contained change with no cross-crate behavioral effect size/M Size: up to 449 counted lines and 10 files; exceeds S in either measure labels Aug 21, 2026
@github-actions github-actions Bot added scope/tooling Build, CI, release, or developer tooling size/L Size: up to 899 counted lines and 20 files; exceeds M in either measure and removed size/M Size: up to 449 counted lines and 10 files; exceeds S in either measure labels Aug 21, 2026
Copilot AI balanced review requested due to automatic review settings August 21, 2026 10:28
Copilot AI reviewed Aug 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Centralizes native TLS and Windows RDPDR integration coverage in the extra testsuite.

Changes:

  • Moves test registration into the shared integration harness.
  • Updates dependencies and xtask TLS checks.
  • Adds Windows filesystem and native TLS fixtures.

Protocol and documentation passes were skipped because runtime protocol behavior and documentation are unchanged.

Reviewed changes

Copilot reviewed 8 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
xtask/src/check.rs Uses the centralized native TLS harness.
crates/ironrdp-tls/src/lib.rs Narrows native TLS conditional import.
crates/ironrdp-tls/Cargo.toml Removes standalone test configuration.
crates/ironrdp-testsuite-extra/tests/tls/native_tls.rs Cleans the migrated TLS test.
crates/ironrdp-testsuite-extra/tests/tls/mod.rs Registers native TLS tests.
crates/ironrdp-testsuite-extra/tests/tls/certs/server-key.pem Adds the TLS test key.
crates/ironrdp-testsuite-extra/tests/tls/certs/server-cert.pem Adds the TLS test certificate.
crates/ironrdp-testsuite-extra/tests/rdpdr/windows_backend.rs Adds Windows backend integration coverage.
crates/ironrdp-testsuite-extra/tests/rdpdr/mod.rs Registers RDPDR tests.
crates/ironrdp-testsuite-extra/tests/main.rs Enables the new test modules.
crates/ironrdp-testsuite-extra/Cargo.toml Adds harness dependencies.
Cargo.lock Records dependency-edge changes.

Comment thread crates/ironrdp-testsuite-extra/Cargo.toml Outdated
Comment thread crates/ironrdp-testsuite-extra/Cargo.toml Outdated
@CBenoit
test: consolidate mstsgu test binary
ee8ab59 
Use one test harness to preserve feature-gated coverage while avoiding repeated relinking.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize mstsgu integration tests
37bf76a 
Move Mstsgu coverage to the shared extra test harness.

Keep native-TLS coverage in the same centralized binary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): group mstsgu integration tests
07910d5 
Nest the Mstsgu integration modules beneath the extra test harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize agent integration tests
3ba897c 
Centralize agent coverage in the extra suite and build the binary once.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize replay integration tests
62d10fa 
Centralize replay coverage in the extra suite and build the binary once.

Preserve gateway, malformed-input, key-log cleanup, and binary invocation coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): fix replay test lint expectation
f75b935 
Rely on the centralized harness allowance after moving RPC-over-HTTP coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize remaining integration tests
4e6d107 
Move native TLS certificate-policy and Windows RDPDR filesystem coverage into the extra testsuite's sole integration harness. Product crates no longer expose standalone Cargo test targets.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
ci(xtask): run centralized TLS test
20cbdba 
Remove commands targeting the deleted TLS test binary so the test checks run the centralized native-TLS harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
fix(tls): gate native TLS import
71501a2 
Only import tokio-native-tls when its native TLS backend feature is enabled. The product crate no longer carries the former test-only dependency.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-centralize-tls-rdpdr-tests branch from 0cdea4f to 71501a2 Compare August 21, 2026 11:09
@CBenoit
test(extra): remove redundant test dependencies
a7ff15d 
Drop placeholder imports and direct dependencies already supplied by the RDPDR test stack.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test: consolidate mstsgu test binary
2e9441d 
Use one test harness to preserve feature-gated coverage while avoiding repeated relinking.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize mstsgu integration tests
6589164 
Move Mstsgu coverage to the shared extra test harness.

Keep native-TLS coverage in the same centralized binary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): group mstsgu integration tests
4102df2 
Nest the Mstsgu integration modules beneath the extra test harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): group mstsgu integration tests
1d2ac4c 
Nest the Mstsgu integration modules beneath the extra test harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): adapt mstsgu test relocation
a0f596a 
Retain upstream Mstsgu coverage in the centralized harness after rebasing.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
ci(xtask): run centralized mstsgu tests
fce25ca 
Keep native TLS smart-card coverage in the extra test harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize added mstsgu tests
97437e9 
Move the Mstsgu integration coverage to the extra suite's sole test binary.

This leaves ironrdp-mstsgu with no Cargo test targets.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
fix(mstsgu): remove obsolete TLS import
e5f7285 
The crate has no test targets, so this import no longer has a supporting dependency.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize agent integration tests
f6f4a52 
Centralize agent coverage in the extra suite and build the binary once.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize replay integration tests
fefd94d 
Centralize replay coverage in the extra suite and build the binary once.

Preserve gateway, malformed-input, key-log cleanup, and binary invocation coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): fix replay test lint expectation
8a3bd7d 
Rely on the centralized harness allowance after moving RPC-over-HTTP coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize remaining integration tests
fbe6a72 
Move native TLS certificate-policy and Windows RDPDR filesystem coverage into the extra testsuite's sole integration harness. Product crates no longer expose standalone Cargo test targets.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
ci(xtask): run centralized TLS test
b2d3468 
Remove commands targeting the deleted TLS test binary so the test checks run the centralized native-TLS harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
fix(tls): gate native TLS import
39aebf7 
Only import tokio-native-tls when its native TLS backend feature is enabled. The product crate no longer carries the former test-only dependency.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): remove redundant test dependencies
451bfbd 
Drop placeholder imports and direct dependencies already supplied by the RDPDR test stack.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): restore PDU test dependency
3d423dc 
Centralized client configuration tests directly use PDU monitor and capability types, so the extra testsuite needs an explicit test-only dependency.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-centralize-tls-rdpdr-tests branch from 2469d5c to 3d423dc Compare August 28, 2026 18:50
@CBenoit
test(extra): centralize remaining integration tests
73b5371 
Move native TLS certificate-policy and Windows RDPDR filesystem coverage into the extra testsuite's sole integration harness. Product crates no longer expose standalone Cargo test targets.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
ci(xtask): run centralized TLS test
c347de2 
Remove commands targeting the deleted TLS test binary so the test checks run the centralized native-TLS harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
fix(tls): gate native TLS import
3b4f847 
Only import tokio-native-tls when its native TLS backend feature is enabled. The product crate no longer carries the former test-only dependency.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): remove redundant test dependencies
7ecfb6f 
Drop placeholder imports and direct dependencies already supplied by the RDPDR test stack.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): restore PDU test dependency
40f2af0 
Centralized client configuration tests directly use PDU monitor and capability types, so the extra testsuite needs an explicit test-only dependency.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): preserve concurrent test changes
cd7a4df 
Integrate concurrent TLS and centralized test changes before updating the replay parent.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): merge replay test updates
119ed34 
Integrate the current replay test parent while retaining centralized TLS and RDPDR coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-centralize-tls-rdpdr-tests branch from 3d423dc to 40f2af0 Compare August 29, 2026 03:44
@CBenoit
fix(daemon): use output event receiver in tests
5932424 
Update daemon status tests for the output-channel receiver API.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
Merge remote-tracking branch 'origin/cbenoit-centralize-tls-rdpdr-tes…
2a092f6 
…ts' into cbenoit-centralize-tls-rdpdr-tests
@glamberson Greg Lamberson (glamberson) mentioned this pull request Aug 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) mamoreau-devolutions approved these changes

Assignees

No one assigned

Labels

maintainer-required Maintainer review or intervention is required risk/unknown Risk could not be determined automatically; needs maintainer-level scrutiny scope/tooling Build, CI, release, or developer tooling size/L Size: up to 899 counted lines and 20 files; exceeds M in either measure

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CBenoit @mamoreau-devolutions