Skip to content

test(extra): centralize agent integration tests - #1744

Open
Benoît Cortier (CBenoit) wants to merge 9 commits into
cbenoit-consolidate-mstsgu-testsfrom
cbenoit-consolidate-agent-tests
Open

test(extra): centralize agent integration tests#1744
Benoît Cortier (CBenoit) wants to merge 9 commits into
cbenoit-consolidate-mstsgu-testsfrom
cbenoit-consolidate-agent-tests

Conversation

@CBenoit

@CBenoit Benoît Cortier (CBenoit) commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Centralize agent coverage in the extra suite and build the binary once.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

@github-actions github-actions Bot added maintainer-required Maintainer review or intervention is required risk/low Self-contained change with no cross-crate behavioral effect size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure labels Aug 21, 2026
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-consolidate-agent-tests branch from 5de0837 to 02ab0ac Compare August 21, 2026 09:10
@CBenoit Benoît Cortier (CBenoit) changed the title test: consolidate agent test binary test(extra): centralize agent integration tests Aug 21, 2026
@github-actions github-actions Bot added size/M Size: up to 449 counted lines and 10 files; exceeds S in either measure and removed size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure labels Aug 21, 2026
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-consolidate-agent-tests branch from 02ab0ac to 3ba897c Compare August 21, 2026 10:56
Copilot AI balanced review requested due to automatic review settings August 28, 2026 15:30
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-consolidate-agent-tests branch from 3ba897c to 11949cf Compare August 28, 2026 15:30
Copilot AI reviewed Aug 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Centralizes agent integration tests in the extra test suite to reuse one agent binary build.

Changes:

  • Moves IPC and live E2E tests into the centralized suite.
  • Adds shared process helpers and updates test documentation.
  • Disables automatic agent integration-test discovery.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/ironrdp-testsuite-extra/tests/main.rs Adds integration-test lint allowances.
crates/ironrdp-testsuite-extra/tests/agent/mod.rs Adds shared agent process helpers.
crates/ironrdp-testsuite-extra/tests/agent/live_e2e.rs Reuses centralized helpers.
crates/ironrdp-testsuite-extra/tests/agent/ipc.rs Hosts the relocated IPC test.
crates/ironrdp-agent/tests/ipc.rs Removes the original IPC test.
crates/ironrdp-agent/README.md Updates the live-test command.
crates/ironrdp-agent/Cargo.toml Disables automatic test targets, including existing unit tests.

Comment thread crates/ironrdp-agent/Cargo.toml
Comment on lines 15 to +17
[lib]
doctest = false
test = false
@github-actions github-actions Bot added risk/unknown Risk could not be determined automatically; needs maintainer-level scrutiny and removed risk/low Self-contained change with no cross-crate behavioral effect labels Aug 28, 2026
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-consolidate-agent-tests branch from 11949cf to 6994578 Compare August 28, 2026 16:52
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-consolidate-agent-tests branch from 6994578 to d3171ec Compare August 28, 2026 18:02
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-consolidate-agent-tests branch from d3171ec to f6f4a52 Compare August 28, 2026 18:40
@CBenoit
test: consolidate mstsgu test binary
08434d6 
Use one test harness to preserve feature-gated coverage while avoiding repeated relinking.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize mstsgu integration tests
7d90f3d 
Move Mstsgu coverage to the shared extra test harness.

Keep native-TLS coverage in the same centralized binary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): group mstsgu integration tests
5b93436 
Nest the Mstsgu integration modules beneath the extra test harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): adapt mstsgu test relocation
2b02193 
Retain upstream Mstsgu coverage in the centralized harness after rebasing.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
ci(xtask): run centralized mstsgu tests
370bfaf 
Keep native TLS smart-card coverage in the extra test harness.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize added mstsgu tests
32ee010 
Move the Mstsgu integration coverage to the extra suite's sole test binary.

This leaves ironrdp-mstsgu with no Cargo test targets.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
fix(mstsgu): remove obsolete TLS import
d4a04e2 
The crate has no test targets, so this import no longer has a supporting dependency.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize rpch v2 test
ddc3f56 
Keep Mstsgu integration coverage in the extra-suite harness so the package exposes no Cargo test target.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
test(extra): centralize agent integration tests
3746d30 
Centralize agent coverage in the extra suite and build the binary once.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
Benoît Cortier (CBenoit) force-pushed the cbenoit-consolidate-agent-tests branch from f6f4a52 to 3746d30 Compare August 29, 2026 03:35
@glamberson Greg Lamberson (glamberson) mentioned this pull request Aug 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) mamoreau-devolutions approved these changes

Assignees

No one assigned

Labels

maintainer-required Maintainer review or intervention is required risk/unknown Risk could not be determined automatically; needs maintainer-level scrutiny size/M Size: up to 449 counted lines and 10 files; exceeds S in either measure

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CBenoit @mamoreau-devolutions