test: consolidate mstsgu test binary

[Benoît Cortier (CBenoit)]

Run the centralized Mstsgu suite with Rustls and retain shared protocol and transport coverage without test-suite feature flags.

[Copilot]

Pull request overview

Consolidates MSTSGU integration tests into one binary to reduce relinking while retaining native-TLS coverage.

Changes:

• Registers a unified integration-test harness.
• Moves native-TLS gating to the http_auth module.
• Updates xtask commands for the new target.

No material findings identified; protocol review was unnecessary because protocol behavior is unchanged.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
xtask/src/check.rs	Targets the consolidated test binary.
crates/ironrdp-mstsgu/Cargo.toml	Disables test autodiscovery and registers one harness.
crates/ironrdp-mstsgu/tests/main.rs	Declares the test modules and feature gate.
crates/ironrdp-mstsgu/tests/http_auth.rs	Removes the now-centralized lint allowance.
crates/ironrdp-mstsgu/tests/http_control.rs	Removes the now-centralized lint allowance.
crates/ironrdp-mstsgu/tests/rpc_pdu.rs	Removes the now-centralized lint allowance.
crates/ironrdp-mstsgu/tests/udp.rs	Removes the now-centralized lint allowance.

[github-actions]

Pure test/build reorganization: mstsgu integration tests move into ironrdp-testsuite-extra, four private proto structs get test-support-gated pub visibility (mirroring the existing test_support pattern), and check.rs drops now-unneeded per-binary invocations. No Encode/Decode/wire-format logic changed. However, the reorg silently drops CI coverage for the smartcard feature's authentication-error tests (no longer exercised anywhere), and leaves one renamed test module (rpc_tsgu_stubs.rs) as an empty no-op stub.

Protocol analysis: accepted — Independently reviewed the diff: HandshakeRespPkt, TunnelReqPkt, ExtendedAuthPkt, and TunnelAuthRespPkt only gain pub visibility gated by #[cfg_attr(not(feature="test-support"), expect(unreachable_pub))], matching the pre-existing test_support.rs pattern used for other packet/config types in this crate. Field layouts, Encode/Decode bodies, and constants are untouched. The handoff's 'none' protocol relevance is correct; I found an additional test-coverage regression, but it is unrelated to wire compatibility.

[github-actions]

blocking / high: Before this PR, xtask/src/check.rs ran `cargo test -p ironrdp-mstsgu --test http_auth --features native-tls,smartcard --locked` (compile and run) as a dedicated CI step, which is the only place in the repo that ever enabled the `smartcard` cargo feature. This PR deletes that step and merges http_auth.rs into ironrdp-testsuite-extra's single test binary, whose only ironrdp-mstsgu dependency features are `rustls` and `test-support` (this line) — `smartcard` is not requested anywhere else in the workspace (verified via grep across all crate Cargo.toml files). The four #[cfg(feature = "smartcard")]-gated tests in http_auth.rs (smart_card_requires_username, smart_card_requires_negotiate, smart_card_rejects_malformed_negotiate_token, smart_card_recognizes_combined_negotiate_challenge) therefore never compile or run in CI going forward, silently losing coverage of the Kerberos PKINIT smart-card authentication error paths (malformed Negotiate tokens, missing username, wrong auth scheme) with no equivalent replacement and no mention in the PR description, which only says 'without test-suite feature flags.'

[github-actions]

non_blocking / low: The old crates/ironrdp-mstsgu/tests/rpc_tsgu_stubs.rs compiled rpc.rs against a deliberately minimal two-variant GwErrorKind (Connect, Custom) as its own separate test binary, as a smoke check that rpc.rs doesn't leak dependencies on more error variants than it directly constructs. The renamed file is now a single blank line, and its former purpose is superseded by main.rs's #[path] mod rpc;, which instead compiles rpc.rs against the full, rich GwErrorKind reused from rpch_http.rs. The empty file and its mod rpc_tsgu_stubs; declaration in mstsgu/mod.rs are vestigial — worth deleting rather than kept as a no-op placeholder that could be mistaken for still providing a check.