DataGrid: Fix the navigateToRow method when navigating down to the bottom row with virtual scrolling enabled#33644
Open
Alyar666 wants to merge 4 commits into
Open
DataGrid: Fix the navigateToRow method when navigating down to the bottom row with virtual scrolling enabled#33644Alyar666 wants to merge 4 commits into
Alyar666 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue in DataGrid virtual scrolling where navigateToRow could scroll incorrectly when navigating down toward the last rows (especially with large datasets/virtual content scaling).
Changes:
- Exposes/threads
getContentOffsetthrough virtual scrolling controllers/adapters with updated typing, and adjusts offset calculation precision. - Adds TestCafe model helpers to target data rows/cells directly.
- Adds an e2e regression test covering
navigateToRowwith virtual scrolling on a large dataset (T1220800).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/testcafe-models/dataGrid/index.ts | Adds getDataRows / getDataCells selector helpers for tests. |
| packages/devextreme/js/__internal/grids/grid_core/virtual_scrolling/types.ts | Introduces a shared ContentOffsetType union type. |
| packages/devextreme/js/__internal/grids/grid_core/virtual_scrolling/m_virtual_scrolling.ts | Makes getContentOffset publicly available on adapter/controller to support virtual scrolling calculations. |
| packages/devextreme/js/__internal/grids/grid_core/virtual_scrolling/m_virtual_scrolling_core.ts | Refines offset computation and types getContentOffset in VirtualScrollController. |
| e2e/testcafe-devextreme/tests/dataGrid/common/scrolling.ts | Adds a regression test for navigateToRow with virtual scrolling and large data. |
Alyar666
force-pushed
the
T1220800_part1_26_1
branch
from
94065bc to
92eddf6
Compare
Alyar666
force-pushed
the
T1220800_part1_26_1
branch
from
78f5a65 to
20fa7e9
Compare
added 4 commits
May 21, 2026 00:55
…ttom row with virtual scrolling enabled
Alyar666
force-pushed
the
T1220800_part1_26_1
branch
from
20fa7e9 to
6981109
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.