Skip to content

fix(cypher): label-filtered edge traversal silently truncates at 10 results #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isc-tdyar wants to merge 1 commit into
base: main
Choose a base branch
from
+42 −10
Open

fix(cypher): label-filtered edge traversal silently truncates at 10 results #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cypher/cypher.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3673,7 +3673,7 @@ static int execute_single(cbm_store_t *store, cbm_query_t *q, const char *projec
scan_pattern_nodes(store, project, max_rows, &pat0->nodes[0], &scanned, &scan_count);

/* Build initial bindings with early WHERE */
int bind_cap = scan_count > 0 ? scan_count : SKIP_ONE;
int bind_cap = scan_count > max_rows ? scan_count : (max_rows > 0 ? max_rows : SKIP_ONE);
binding_t *bindings = malloc((bind_cap + SKIP_ONE) * sizeof(binding_t));
int bind_count = 0;
const char *var_name = pat0->nodes[0].variable ? pat0->nodes[0].variable : "_n0";
Expand Down
50 changes: 41 additions & 9 deletions tests/test_incremental.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,8 @@ TEST(incr_modify_file) {

/* Single-file incremental should be faster than full */
if ((int)ms > (int)(g_full_index_ms * 1.5)) {
printf(" [PERF WARNING] incremental slower than 1.5x full: %.0fms vs %.0fms\n",
ms, g_full_index_ms);
printf(" [PERF WARNING] incremental slower than 1.5x full: %.0fms vs %.0fms\n", ms,
g_full_index_ms);
}

printf(" [perf] modify 1 file: %.0fms (full was %.0fms)\n", ms, g_full_index_ms);
Expand Down Expand Up @@ -910,12 +910,12 @@ static int resp_lacks_key(const char *resp, const char *key) {
}

/* Helper: assert tool call succeeds, warn if slow */
#define TOOL_OK(resp, ms) \
do { \
ASSERT((resp) != NULL); \
if ((int)(ms) > PERF_WARN_MS) { \
#define TOOL_OK(resp, ms) \
do { \
ASSERT((resp) != NULL); \
if ((int)(ms) > PERF_WARN_MS) { \
printf(" [PERF WARNING] tool call: %.0fms (>%dms)\n", (ms), PERF_WARN_MS); \
} \
} \
} while (0)

/* Helper: assert response is not an error */
Expand All @@ -932,6 +932,38 @@ TEST(tool_list_projects_basic) {
PASS();
}

TEST(tool_qg_defines_method_more_than_10) {
write_file_at("fastapi/big_class.py", "class BigClass:\n"
" def m1(self): pass\n"
" def m2(self): pass\n"
" def m3(self): pass\n"
" def m4(self): pass\n"
" def m5(self): pass\n"
" def m6(self): pass\n"
" def m7(self): pass\n"
" def m8(self): pass\n"
" def m9(self): pass\n"
" def m10(self): pass\n"
" def m11(self): pass\n"
" def m12(self): pass\n"
" def m13(self): pass\n"
" def m14(self): pass\n"
" def m15(self): pass\n");
char *idx = index_repo();
ASSERT(idx != NULL);
free(idx);
double ms;
char *r = call_tool_timed("query_graph", &ms,
"{\"project\":\"%s\","
"\"query\":\"MATCH (c:Class)-[:DEFINES_METHOD]->(m:Method)"
" WHERE c.name = 'BigClass' RETURN count(m) AS n\"}",
g_project);
TOOL_OK(r, ms);
ASSERT(strstr(r, "\"15\"") != NULL || strstr(r, "\\\"15\\\"") != NULL);
free(r);
PASS();
}

TEST(tool_list_projects_has_current) {
double ms;
char *r = call_tool_timed("list_projects", &ms, "{}");
Expand Down Expand Up @@ -2824,8 +2856,7 @@ SUITE(incremental) {
return;
}

int skip_perf = (getenv("CBM_SKIP_PERF") != NULL &&
getenv("CBM_SKIP_PERF")[0] != '0' &&
int skip_perf = (getenv("CBM_SKIP_PERF") != NULL && getenv("CBM_SKIP_PERF")[0] != '0' &&
getenv("CBM_SKIP_PERF")[0] != '\0');

/* Phase 1: Full index baseline (needed for tool tests below) */
Expand Down Expand Up @@ -3050,6 +3081,7 @@ SUITE(incremental) {
RUN_TEST(tool_qg_configures);
RUN_TEST(tool_qg_handles);
RUN_TEST(tool_qg_defines_method);
RUN_TEST(tool_qg_defines_method_more_than_10);
RUN_TEST(tool_qg_no_limit);
RUN_TEST(tool_qg_empty_result);

Expand Down