docs(triage_engine): condition operators follow the field's data type - #16035
Open
blakeaowens wants to merge 1 commit into
Open
blakeaowens wants to merge 1 commit into
blakeaowens wants to merge 1 commit into
Conversation
Two corrections and one promotion, all of them things the page already implied but did not deliver. The date note said comparisons order ISO-8601 strings "correctly as text". That was the design, and it was wrong for the three fields that carry a time of day: compared as text, "mitigated lte 2026-08-27" excluded every Finding mitigated on the 27th. Dates now compare as dates, by calendar day whenever the value you write is a calendar day, so the page says that instead and spells out how to ask for finer than a day when you need it. "The field's data type decides which operators the editor offers" was true of custom fields only, and sat in the custom-fields section. It is now true of every field, so it moves up under Conditions as a table, gains the list-valued row (vulnerability_ids and tags, where eq could never match), and names the two ordered code vocabularies that keep their comparison operators. Also documents the "unsupported" label a reader may meet on an existing rule, and adds risk_acceptance_expiration_date to the date field lists. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the Triage Engine condition documentation on two points the page got wrong, and promotes a third that was only half true.
Dates compare as dates. The page said ISO-8601 values "order correctly as text". That was the design, and it was wrong for the three fields that carry a time of day: compared as text,
mitigated lte 2026-08-27excluded every Finding mitigated on the 27th,gtincluded them, andeqcould never hold. The page now says dates are compared chronologically, that a calendar value covers the whole of that day, and how to ask for finer precision on a field that carries a time.Operators follow the field's data type. This was stated only in the custom-fields section, where it was true. It now describes every field, so it moves up under Conditions as a table, gains the list-valued row (
vulnerability_ids,tags, where equality compares the whole list against one value and so can never match), and names the two ordered code vocabularies that keep their comparison operators.Also documents the "unsupported" label a reader may meet on an existing rule, and adds
risk_acceptance_expiration_dateto the date field lists.English only, matching every prior content change to this page.
Pairs with a DefectDojo Pro change on the same release line.
Test Commands
/test all— run all testsTest Configuration