Conversation
…e sizing Add a "what each knob does" table for the uWSGI/Celery application-tier settings, and a new "Tuning the database" section covering the PostgreSQL settings that matter most for DefectDojo's aggregation-heavy reads (shared_buffers, effective_cache_size, work_mem, maintenance_work_mem, max_connections), plus a connection-budget subsection tying the application tier and database together. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pages carry an audience (pro/opensource); general pages have none. Stamp data-dd-version from the page's own audience before first paint and persist it, so a deep link to a Pro page puts the reader in the Pro section (with the matching sidebar) instead of leaving them in their stored edition's nav around Pro content. General pages keep the stored preference. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Found 5 issues across 5 rules (3 WCAG, 2 Best Practice).
Reviewed by AccessLint, which checks every pull request for accessibility issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortcut: sc-15512
Two small, independent docs changes on top of the on-prem Pro restructure (#15959), kept as separate commits.
1. Hardware sizing: tuning knobs and their effects
docs/content/get_started/pro/onprem/hardware_sizing.mdReaders asked what to actually turn and what each setting does. This adds:
DD_UWSGI_NUM_OF_PROCESSES,DD_UWSGI_NUM_OF_THREADS,DD_CELERY_WORKER_CONCURRENCY,DD_CELERY_WORKER_AUTOSCALE_MAX) with starting points and the effect of raising each.shared_buffers,effective_cache_size,work_mem,maintenance_work_mem,max_connections, with starting points and what each controls.(uWSGI processes × threads) + Celery concurrency.The guidance is grounded in a
dojo-compose-clideployment exercised across finding volumes (300K → 5M): read latency is flat from 300K to 1M (app-CPU bound on concurrent users), then the database becomes the constraint as query cost grows with row count — which is what the existing per-tier DB scaling already accounts for. No table figures changed; this fills the "how do I tune it" gap.2. Deep links land in the page's own edition
docs/layouts/_partials/head/custom-head.htmlThe docs have an Open Source / Pro edition toggle keyed off
html[data-dd-version], sourced only fromlocalStorage(defaultopensource). A deep link to a Pro page therefore left a reader in whatever edition they had, so the Pro page rendered with the OS sidebar around it — you were "on a Pro page" without being "in the Pro section."This stamps
data-dd-versionfrom the page's ownaudiencebefore first paint and persists it: a Pro page switches the reader into Pro (matching sidebar), an Open Source page into OS, and general pages keep the stored preference.Testing
hugo --gc --minify: clean build, no errors.🤖 Generated with Claude Code