refactor(pchronicle): unify unknown fields and JSON streaming - #80
Merged
Conversation
reiase
force-pushed
the
refactor/pchronicle-unknown-fields-streaming
branch
from
August 20, 2026 00:37
86b3011 to
2a40260
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StorylinePresenceand format-specific residual metadata with one bounded RFC 6901unknown_fieldsmechanism_storylinecarry envelope instead of repairingunknown_key_countsafter decodingstepsdecoding and filter pushdownschema_version: 1to the atomic Storyline LanceCURRENTpointer and fail closed before opening tables when it is missing or unsupportedReview follow-up
owned_countswriteback and closed the envelope validation gapJSON streaming benchmark
Local release benchmark on Darwin 25.5.0 arm64, Apple M4, 24 GiB RAM, rustc 1.97.1. Scale 128, 20 iterations,
PCHRONICLE_BENCH_PATH=both.Commands:
Observed process peak RSS was 35.016/113.406 MiB for ATIF NDJSON, 34.609/112.750 MiB for ATIF array, and 30.547/38.312 MiB for ACTF array. RSS is the process peak from a shared projected-then-full invocation; latency and allocation counters are the direct paired measurements.
Validation
cargo test -p persisting-pchronicle --features lance-store— 311 unit and 69 integration tests passed; 5 opt-in or external-service tests ignoredcargo test -p persisting-dlcapt --locked— 19 unit and 24 integration tests passedcargo clippy -p persisting-pchronicle --lib --locked -- -D warnings -D clippy::unwrap_used -D clippy::expect_used -D clippy::unreachablecargo clippy -p persisting-pchronicle --all-targets --features lance-store -- -D warningscargo clippy -p persisting-dlcapt --lib --bin dlcapt --locked -- -D warningscargo fmt --all --checkjust docs-linksgit diff --check