chore: shrink detekt baseline 415 → 410 (genuine cleanups only)#162
Merged
Conversation
Lowest-hanging detekt-baseline reductions that genuinely IMPROVE the code
(not mechanical line-wraps — the bulk of the MaxLineLength baseline is
intentional: table-aligned test fixtures and inline JSON wire-templates,
which read worse if wrapped, so left alone).
- ClaudeClient / OpenAiClient: `kotlinx.coroutines.flow.FlowCollector`
inline FQN -> an import in all three `parseSseStream`-related signatures
(shorter, clearer; -3 MaxLineLength).
- ClaudeClient: wrap the over-long `cacheControl` conditional (-1).
- OpenAiClient: wrap the over-long provider-error throw (-1).
- MockTcpMcpServer: the unused `private val acceptThread` becomes an
`init { }` block — same start-on-construction, no retained handle
(-1 UnusedPrivateProperty). TcpTransportTest stays green.
Full ./gradlew build green; all tests pass; baseline ratchet tightened to 410.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowest-hanging detekt-baseline reductions that genuinely improve the code — not a mechanical line-wrap spree. On inspection the bulk of the
MaxLineLengthbaseline is intentional (table-aligned test fixtures, inline JSON wire-templates) and reads worse if wrapped, so I left it alone. Only the genuinely-clean code changes:ClaudeClient/OpenAiClient—kotlinx.coroutines.flow.FlowCollectorinline FQN → animportin all threeparseSseStreamsignatures (shorter, clearer; −3MaxLineLength).ClaudeClient— wrap the over-longcacheControlconditional (−1).OpenAiClient— wrap the over-long provider-errorthrow(−1).MockTcpMcpServer— the unusedprivate val acceptThreadbecomes aninit { }block (same start-on-construction, no retained handle; −1UnusedPrivateProperty).TcpTransportTeststays green.Full
./gradlew buildgreen; all tests pass; the ratchet tightens 415 → 410.🤖 Generated with Claude Code