Conversation
- Removed empty config.cfg hack (it was an ancient workaround for a problem that no longer exists) - Updated ruff formatter config to format as python3.12 (the version of python used by the project) - Fixed some outdated readme text - Upgraded mypy version - Fixed type hint complaints from mypy - Updated pytest & pytest plugin versions (fixes several noisy deprecation warnings)
induane
force-pushed
the
pkg-and-dep-tweak
branch
from
April 16, 2026 10:39
9b3f723 to
34815a2
Compare
Contributor
Author
|
@rboni-dk @aarthy-dk @datakitchen-devops this has been up a spell (I just rebased it). Are you all active accepting commits? |
aarthy-dk
requested changes
Sep 22, 2026
| project_ids: list[str] = field(default_factory=list) | ||
| run_ids: list[str] = field(default_factory=list) | ||
| run_keys: list[str] = field(default_factory=list) | ||
| search: Optional[str] = None |
Contributor
There was a problem hiding this comment.
This one got dropped, likely during a conflict resolution. It was added more recently.
| TASK_ID_QUERY_NAME, | ||
| DATE_RANGE_START_QUERY_NAME, | ||
| DATE_RANGE_END_QUERY_NAME, | ||
| SEARCH_QUERY_NAME, |
Contributor
There was a problem hiding this comment.
The Optional import is unused in this file after the changes. Could you drop it?
Contributor
|
Apologies @induane, we lost track of this one - thanks for the ping! I left some comments on your changes. Some newer fields in one of the files got dropped. Good to merge in after that is fixed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.