Skip to content

test(dotnet): revert easywins for OtelTracestate sampling, disable IAST in sampling scenario - #7632

Merged
MilanGarnier merged 5 commits into
mainfrom
milan.garnier/disable-dotnet-otel-tracestate-easy-wins
Sep 3, 2026
Merged

test(dotnet): revert easywins for OtelTracestate sampling, disable IAST in sampling scenario#7632
MilanGarnier merged 5 commits into
mainfrom
milan.garnier/disable-dotnet-otel-tracestate-easy-wins

Conversation

@MilanGarnier

@MilanGarnier MilanGarnier commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

These were activated by easy win script but some will be marked as bug
Moreover, IAST flags the payload in make_distant_call and makes a force keeps which would break the test in python, dotnet, Java and PHP. Action: move the impacted test to the sampling scenario, and restrict the a SamplingTest to its own spans (because the moved test involve manual keep)

Summary

  • disable the .NET parametric and end-to-end OTel tracestate sampling suites
  • run every end-to-end OTel tracestate test in SAMPLING instead of DEFAULT
  • disable AppSec and IAST in the SAMPLING scenario
  • remove only the OTel tracestate activations introduced by the automated easy-win PR

All .NET declarations retain the APMAPI-2171 missing-feature marker.

@MilanGarnier
MilanGarnier requested a review from a team as a code owner September 2, 2026 11:47
@MilanGarnier
MilanGarnier requested review from duviduduvid and removed request for a team September 2, 2026 11:47
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
tests/test_otel_tracestate_sampling.py                                  @DataDog/system-tests-core
tests/test_sampling_rates.py                                            @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core

@MilanGarnier
MilanGarnier requested a review from a team as a code owner September 2, 2026 11:54
@MilanGarnier MilanGarnier changed the title test(dotnet): disable OTel tracestate sampling tests test(dotnet): revert easywins for OtelTracestate sampling, disable IAST in sampling scenario Sep 2, 2026
@MilanGarnier
MilanGarnier requested a lite review from Copilot September 2, 2026 12:19
@MilanGarnier
MilanGarnier requested a review from genesor September 2, 2026 12:21
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 2, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

⚠️ Your PR has warnings. Please review the issues below.

🚦 1 Pipeline job failed

Testing the test | all-jobs-are-green

View more details · View in GitHub Actions

Some CI checks or statuses failed, please check the summary table.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0f526db | Docs | View more details | Give us feedback!

This comment was marked as resolved.

@MilanGarnier
MilanGarnier enabled auto-merge (squash) September 2, 2026 12:55
@MilanGarnier

Copy link
Copy Markdown
Contributor Author

Tried to use decision maker (checking manual keep), but dd-trace-dotnet does not emit it for the root span so I fall back on limiting the scope to the spans emitted for the test.

@MilanGarnier

Copy link
Copy Markdown
Contributor Author

/merge -m squash

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 2, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-02 16:07:53 UTC ℹ️ Start processing command /merge -m squash


2026-09-02 16:08:06 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-09-02 21:04:33 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@MilanGarnier
MilanGarnier merged commit 5fa231d into main Sep 3, 2026
2839 of 2842 checks passed
@MilanGarnier
MilanGarnier deleted the milan.garnier/disable-dotnet-otel-tracestate-easy-wins branch September 3, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants