Skip to content

Add test to verify that _dd.span_links span_id is zero-padded to 16 hex chars - #7627

Open
mcculls wants to merge 2 commits into
mainfrom
mcculls/assert-span-link-id-zero-padded
Open

Add test to verify that _dd.span_links span_id is zero-padded to 16 hex chars#7627
mcculls wants to merge 2 commits into
mainfrom
mcculls/assert-span-link-id-zero-padded

Conversation

@mcculls

@mcculls mcculls commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Motivation

Relevant section of the RFC: https://docs.google.com/document/d/1RcTjO8ER5FNweJ0rqVcQEbf6tb1PrlPsQ6coZZww8Xg/edit?tab=t.0#heading=h.pwna8rp9exnf

Current test checks linking to a random span-id, which may or may not need padding. The new test uses a span-id that will definitely require padding.

Changes

Add test to specifically verify that _dd.span_links span_id is zero-padded to 16 hex chars

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/cpp.yml                                                       @DataDog/system-tests-reviewers
manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
tests/parametric/test_span_links.py                                     @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 1, 2026

Copy link
Copy Markdown

Tests

All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 584fced | Docs | View more details | Give us feedback!

@mcculls
mcculls force-pushed the mcculls/assert-span-link-id-zero-padded branch from 8e4f209 to 02538a4 Compare September 1, 2026 18:29
@mcculls
mcculls marked this pull request as ready for review September 1, 2026 18:57
@mcculls
mcculls requested review from a team as code owners September 1, 2026 18:57
@mcculls
mcculls requested review from colin-higgins and zacharycmontoya and removed request for a team September 1, 2026 18:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02538a4338

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/parametric/test_span_links.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant