Add test to verify that _dd.span_links span_id is zero-padded to 16 hex chars - #7627
Open
mcculls wants to merge 2 commits into
Open
Add test to verify that _dd.span_links span_id is zero-padded to 16 hex chars#7627mcculls wants to merge 2 commits into
_dd.span_links span_id is zero-padded to 16 hex chars#7627mcculls wants to merge 2 commits into
Conversation
Contributor
|
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 584fced | Docs | View more details | Give us feedback! |
…ex chars, per the RFC
mcculls
force-pushed
the
mcculls/assert-span-link-id-zero-padded
branch
from
September 1, 2026 18:29
8e4f209 to
02538a4
Compare
mcculls
marked this pull request as ready for review
September 1, 2026 18:57
mcculls
requested review from
colin-higgins and
zacharycmontoya
and removed request for
a team
September 1, 2026 18:57
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02538a4338
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Relevant section of the RFC: https://docs.google.com/document/d/1RcTjO8ER5FNweJ0rqVcQEbf6tb1PrlPsQ6coZZww8Xg/edit?tab=t.0#heading=h.pwna8rp9exnf
Current test checks linking to a random span-id, which may or may not need padding. The new test uses a span-id that will definitely require padding.
Changes
Add test to specifically verify that
_dd.span_links span_idis zero-padded to 16 hex charsWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present