Skip to content

Accept empty V1 fields#7348

Merged
AlexeyKuznetsov-DD merged 1 commit into
mainfrom
alexeyk/accept-empty-v1-fields
Jul 21, 2026
Merged

Accept empty V1 fields#7348
AlexeyKuznetsov-DD merged 1 commit into
mainfrom
alexeyk/accept-empty-v1-fields

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

Motivation

v1 binary payloads encode empty attributes and tracestate fields, while legacy JSON payloads omit them. Both representations are equivalent.

Changes

Updates OpenTelemetry span-event and span-link assertions to accept optional fields that are either omitted or explicitly empty.

Additional Notes

Validated the span-link test locally.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Jul 20, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code owners July 20, 2026 21:29
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from MilanGarnier and removed request for a team July 20, 2026 21:29
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/parametric/test_otel_span_methods.py                              @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD merged commit 55c94b5 into main Jul 21, 2026
426 checks passed
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD deleted the alexeyk/accept-empty-v1-fields branch July 21, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants