Fix Java parametric protocol selection#7347
Merged
Merged
Conversation
AlexeyKuznetsov-DD
requested review from
dougqh,
dromanol and
manuel-alvarez-alvarez
July 20, 2026 17:51
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
This PR fixes Java parametric runs so the shared protocol selector (DD_TRACE_API_VERSION: v0.4, v0.5, v1.0) is correctly applied to the Java tracer via DD_TRACE_AGENT_PROTOCOL_VERSION, while preserving any explicit Java-side configuration already set by the user/environment.
Changes:
- Adds a translation layer in the Java parametric Docker launcher to map
DD_TRACE_API_VERSION→DD_TRACE_AGENT_PROTOCOL_VERSIONwhen the latter is not already set. - Supports the shared protocol values
v0.4,v0.5, andv1.0by converting them to the Java-expected format (0.4,0.5,1.0).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ajgajg1134
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Java parametric scenarios requesting
v0.5, but actually ignored bydd-trace-javatracer.As specified in RFC: Efficient Trace Payload Protocol. Protocol can be specified via:
DD_TRACE_AGENT_PROTOCOL_VERSIONvariable. And default value isv0.4for now.Changes
Maps shared
DD_TRACE_API_VERSIONvalues (v0.4,v0.5, andv1.0) to the Java tracer settingDD_TRACE_AGENT_PROTOCOL_VERSIONin the parametric launcher while preserving explicit Java configuration.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present