chore(ruff): resolve lint exceptions for virtual_machine provider/pro…#7344
Merged
robertomonteromiguel merged 1 commit intoJul 20, 2026
Merged
Conversation
Contributor
|
|
robertomonteromiguel
marked this pull request as ready for review
July 20, 2026 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up the per-file ruff ignores for
utils/virtual_machine/virtual_machine_provider.pyandutils/virtual_machine/virtual_machine_provisioner.pyby fixing the underlying violations instead of suppressing them. Only safe, behavior-preserving changes were made; risky ones were intentionally left marked with an explanatory comment.Changes
utils/virtual_machine/virtual_machine_provider.py— removed 10 ignored rules:RET505: replacedelif/else-after-returnwith plainifguards inget_provider.ANN201: added return type annotations (-> Noneand-> pulumi_command.remote.Command).E731: converted theoutput_callbacklambda into a nesteddef.E501: wrapped an over-long comment and split a long shell-command string via implicit concatenation (value unchanged).PTH112/PTH119: replacedos.path.isdir(...)/os.path.basename(...)withpathlib.Pathequivalents.A002: renamed the shadowingidparameter tocopy_idin the basecopy_filestub.ARG002: prefixed the unusedvm/serverargs of the basecreate_cachewith_.F541: dropped the uselessfprefix.FBT002: stale entry (no actual violation), also removed.Intentionally kept (risky / would break behavior)
PLC0415(virtual_machine_provider.py): the imports insideget_providerare deliberate lazy imports that avoid circular dependencies between provider modules. Kept with an explanatory comment.S506(virtual_machine_provisioner.py):yaml.load(..., Loader=yaml.FullLoader)can't becomeyaml.safe_loadbecauseYamlIncludeConstructoris registered againstFullLoaderto support!includein the provision YAMLs.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present