Skip to content

feat: enable agent stats computation by default#146

Open
duncanpharvey wants to merge 1 commit into
mainfrom
duncan-harvey/agent-computed-trace-stats-enabled
Open

feat: enable agent stats computation by default#146
duncanpharvey wants to merge 1 commit into
mainfrom
duncan-harvey/agent-computed-trace-stats-enabled

Conversation

@duncanpharvey

@duncanpharvey duncanpharvey commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Enable agent stats computation by default
  • Set client_drop_p0s to false when agent stats computation is enabled
  • Ignore Datadog-Client-Computed-Stats when agent stats computation is enabled
  • Drop stats sent from tracer to /v0.6/stats when agent stats computation is enabled

Motivation

https://docs.google.com/document/d/1RudMlGPZgvPDOaU6VTGW5Z5NuZzZswcPHLzuuOIX0YQ/edit?usp=sharing

https://datadoghq.atlassian.net/browse/SVLS-9033

Additional Notes

See attached card for additional test cases.

Describe how to test/QA your changes

Made 10,000 requests with plow "$url" -c 50 -n 10000 and validated that the correct number of spans and trace stats are received by Datadog.

100% sampling, agent stats enabled, tracer stats disabled ✅

Screenshot 2026-07-22 at 4 48 02 PM

100% sampling, agent stats disabled, tracer stats enabled ⚠️ - minor discrepancies in tracer computed stats for Java and .NET to be investigated in a follow up ticket

Screenshot 2026-07-22 at 4 49 53 PM

100% sampling, agent stats enabled, tracer stats disabled ✅

Screenshot 2026-07-22 at 5 00 41 PM

100% sampling, agent stats disabled, tracer stats enabled ⚠️ - minor discrepancies in tracer computed stats for .NET to be investigated in a follow up ticket
Screenshot 2026-07-22 at 5 02 46 PM

@duncanpharvey
duncanpharvey force-pushed the duncan-harvey/agent-computed-trace-stats-enabled branch from afec267 to bc51ee7 Compare July 17, 2026 15:07
@duncanpharvey
duncanpharvey marked this pull request as ready for review July 22, 2026 21:10
@duncanpharvey
duncanpharvey requested a review from a team as a code owner July 22, 2026 21:10
@duncanpharvey
duncanpharvey requested review from apiarian-datadog and Copilot and removed request for a team and Copilot July 22, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant