Repository navigation
Fix CTE AS normalization with alias removal - #112
Open
joelmarcotte wants to merge 2 commits into
Open
joelmarcotte wants to merge 2 commits into
joelmarcotte wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASin PostgreSQL CTE headers, includingMATERIALIZEDandNOT MATERIALIZEDforms.Validation
go test ./... -count=1git diff --checkPerformance
On Apple M5 Pro with Go 1.27.1,
go test -run '^$' -bench '^BenchmarkCTENormalization$' -benchtime=300ms -count=7 -cpu=1compared withmain:The corrected CTE path takes 7–11% longer than the baseline, which discards CTE syntax. The allocation profile attributes no heap allocations to the CTE tracker for these cases. A five-deep CTE exceeds the inline frame capacity and uses one extra allocation.
Compatibility
Affected CTE normalization output changes when alias retention is disabled. Consumers that derive query signatures from normalized SQL may see new signatures for those queries.