Skip to content

Paginate API calls in Documentation Team Approval check #39409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hestonhoffman wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −5
Open

Paginate API calls in Documentation Team Approval check #39409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/codeowner_review_status.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,12 @@ jobs:
const DOCUMENTATION_TEAM = 'documentation';
const WEBOPSTEAM = 'webops-platform';

// Get all reviews
const { data: reviews } = await github.rest.pulls.listReviews({
// Get all reviews (paginated: PRs can exceed the 30-item default page size)
const reviews = await github.paginate(github.rest.pulls.listReviews, {
owner,
repo,
pull_number: number,
per_page: 100,
});

// Track latest review state per user (ignore commented state)
Expand Down Expand Up @@ -87,6 +88,7 @@ jobs:
owner,
repo,
pull_number: number,
per_page: 100,
});

// Check if documentation or webops-platform teams are currently in requested reviewers
Expand All @@ -95,14 +97,16 @@ jobs:
);

// Also check if any documentation or webops-platform team member has reviewed (indicating they were requested)
const { data: docTeamMembers } = await github.rest.teams.listMembersInOrg({
const docTeamMembers = await github.paginate(github.rest.teams.listMembersInOrg, {
org: owner,
team_slug: DOCUMENTATION_TEAM,
per_page: 100,
});
const { data: webopsTeamMembers } = await github.rest.teams.listMembersInOrg({

const webopsTeamMembers = await github.paginate(github.rest.teams.listMembersInOrg, {
org: owner,
team_slug: WEBOPSTEAM,
per_page: 100,
});

const teamMembers = [...docTeamMembers, ...webopsTeamMembers];
Expand Down
Loading