Repository navigation
build: libdatadog to v48, adapt debugger ABI - #4444
Conversation
Regenerate the FFI headers and handle CaptureValue.size as a uint64_t. This prevents an ABI mismatch that crashes exception replay.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The FFI header and exception serializer consistently represent CaptureValue.size as uint64_t, and the replay expectation matches the numeric size. Runtime ABI behavior remains unverified.
🤖 Bits Code Review · Commit 643224f
|
And fix two missed size truncations
Benchmarks [ tracer ]Benchmark execution time: 2026-11-06 18:41:28 Comparing candidate commit e35412c in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 0 unstable metrics.
|
Description
Regenerate the FFI headers and handle
CaptureValue.sizeas auint64_t. This prevents an ABI mismatch that crashes exception replay.Introduced by DataDog/libdatadog#2810.
Also adds PHP <8.6.0RC5 to the list of versions to skip for
gh20838.phpt.Reviewer checklist