Skip to content

build: libdatadog to v48, adapt debugger ABI - #4444

Merged
morrisonlevi merged 3 commits into
masterfrom
levi/libdatadog-48
Nov 6, 2026
Merged

morrisonlevi merged 3 commits into
masterfrom
levi/libdatadog-48

Conversation

@morrisonlevi

@morrisonlevi morrisonlevi commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Regenerate the FFI headers and handle CaptureValue.size as a uint64_t. This prevents an ABI mismatch that crashes exception replay.

Introduced by DataDog/libdatadog#2810.

Also adds PHP <8.6.0RC5 to the list of versions to skip for gh20838.phpt.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Regenerate the FFI headers and handle CaptureValue.size as a uint64_t.
This prevents an ABI mismatch that crashes exception replay.
@morrisonlevi
morrisonlevi requested review from a team as code owners November 6, 2026 16:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T16:23:31.524247Z 643224f PR opened
🔒 Security Review ✅ Completed 2026-11-06T16:24:26.917411Z 643224f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The FFI header and exception serializer consistently represent CaptureValue.size as uint64_t, and the replay expectation matches the numeric size. Runtime ABI behavior remains unverified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 643224f

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

Your PR has warnings. Please review the issues below.

🚦 4 Pipeline jobs failed

DDCI - DataDog/dd-trace-php | dsm-throughput

View more details · View in DDCI

DDCI - DataDog/dd-trace-php | publish docker image for system tests

View more details · View in DDCI

DataDog/apm-reliability/dd-trace-php | dsm-throughput

View more details · View in GitLab

View all 4 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 79.86% (-0.13%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e35412c | Docs | View more details | Give us feedback!

@morrisonlevi
morrisonlevi enabled auto-merge (squash) November 6, 2026 16:48
And fix two missed size truncations
@pr-commenter

pr-commenter Bot commented Nov 6, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-11-06 18:41:28

Comparing candidate commit e35412c in PR branch levi/libdatadog-48 with baseline commit b89e238 in branch master.

📊 Benchmarking dashboard

Found 1 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1.962µs; -0.838µs] or [-11.211%; -4.789%]

@morrisonlevi
morrisonlevi merged commit 16baa69 into master Nov 6, 2026
2349 checks passed
@morrisonlevi
morrisonlevi deleted the levi/libdatadog-48 branch November 6, 2026 18:48
@github-actions github-actions Bot added this to the 1.28.0 milestone Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants