[NOJIRA] [FIX] [V2] Session Replay build issues

[cdn34dd]

What does this PR do?

This PR does two things:

• Refactors the session-replay podspec file to properly align with newer versions of React Native, removing Folly flags and restructuring install_modules_dependencies. This solves build issues and potential hangups during the process.
• Closes the chokidar watcher after bundle_build_done so the Node process is able to exit, avoiding potential hangups that will hold up the build process.

Additional Notes

Tested on an specific Expo 54.0.33 RN 0.81.5 test app.

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests
• Make sure you discussed the feature or bugfix with the maintaining team in an Issue
• Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
• If this PR is auto-generated, please make sure also to manually update the code related to the change

[Copilot]

Pull request overview

Addresses build stability issues for the Session Replay package by updating iOS CocoaPods configuration for newer React Native versions and preventing Metro/Node processes from hanging after bundling completes.

Changes:

• Refactors the Session Replay podspec to remove Folly-specific flags and restructure install_modules_dependencies / xcconfig handling for newer RN.
• Updates the Metro asset bundler to manage a single chokidar watcher instance and close it after bundling-related reporter events to allow Node to exit.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
packages/react-native-session-replay/src/metro/index.ts	Replaces boolean “watching” guard with a chokidar watcher instance and adds logic to close it after Metro reporter events.
packages/react-native-session-replay/DatadogSDKReactNativeSessionReplay.podspec	Simplifies new-arch compiler flags and reorganizes pod_target_xcconfig + install_modules_dependencies handling.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The watcher is closed not only on bundle_build_done but also on transformer_load_done. transformer_load_done can fire early (before assets are added / before bundling finishes), which can stop the chokidar watcher prematurely and cause newly added SVGs to never be merged. Consider only closing the watcher on bundle_build_done (or otherwise gating the close to one-off bundle/CI builds).

Suggested change

	mergeSvgAssets(assetsDir);
	mergeSvgAssets(assetsDir);
	}
	if (event.type === 'bundle_build_done') {

[Copilot]

There’s no automated coverage around the new lifecycle behavior (closing the chokidar watcher after a Metro reporter event). Since this affects build stability and can differ between dev server vs one-off bundling, adding a unit test that mocks chokidar and asserts when close() is (and is not) called would help prevent regressions.