Skip to content

Predeclare spotless dependency on googleJavaFormat - #108

Merged
mcculls merged 1 commit into
mainfrom
mcculls/fix-intermittent-spotless-error
Aug 26, 2026
Merged

Predeclare spotless dependency on googleJavaFormat#108
mcculls merged 1 commit into
mainfrom
mcculls/fix-intermittent-spotless-error

Conversation

@mcculls

@mcculls mcculls commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What Does This Do

Predeclare spotless dependency on googleJavaFormat so it downloads it once, rather than multiple modules racing to download it

Motivation

Avoids this intermittent error:

  Execution failed for task ':class-inject:spotlessJavaCheck' (registered by plugin 'java-common').
  > There were 4 lint error(s), they must be fixed or suppressed.
    src/glue/java/datadog/instrument/glue/DefineClassGlueGenerator.java:LINE_UNDEFINED google-java-format(java.lang.NoClassDefFoundError) com/google/common/collect/ImmutableSet$Builder (...)
    src/main/java/datadog/instrument/classinject/ClassInjector.java:LINE_UNDEFINED google-java-format(java.lang.NoClassDefFoundError) com/google/common/collect/ImmutableSet$Builder (...)
    src/main/java/datadog/instrument/classinject/package-info.java:LINE_UNDEFINED google-java-format(java.lang.NoClassDefFoundError) com/google/common/collect/ImmutableSet$Builder (...)
    src/test/java/datadog/instrument/glue/DefineClassGlueGeneratorTest.java:LINE_UNDEFINED google-java-format(java.lang.NoClassDefFoundError) com/google/common/collect/ImmutableSet$Builder (...)
    Resolve these lints or suppress with `suppressLintsFor

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

… once, rather than multiple modules racing to download it
@mcculls
mcculls marked this pull request as ready for review August 26, 2026 13:34
@mcculls
mcculls requested a review from a team as a code owner August 26, 2026 13:34
@mcculls
mcculls requested review from bric3 and removed request for a team August 26, 2026 13:34
@mcculls
mcculls merged commit a461697 into main Aug 26, 2026
8 checks passed
@mcculls
mcculls deleted the mcculls/fix-intermittent-spotless-error branch August 26, 2026 15:09
@mcculls mcculls added this to the 0.0.5 milestone Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants