Skip to content

Use raw manifest to create shared configs and dependencies - #3559

Open
khewonc wants to merge 4 commits into
mainfrom
khewonc/fix-defaulted-profile-overlays
Open

khewonc wants to merge 4 commits into
mainfrom
khewonc/fix-defaulted-profile-overlays

Conversation

@khewonc

@khewonc khewonc commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Uses the user provided manifest instead of a defaulted manifest to create shared configs and dependencies for profiles and ddas. Previously, we used the defaulted manifest, so we couldn't tell if a config was set by the user or defaulted. For profile overlays, this meant we'd favor a defaulted (but unset) config over a user-set profile config

Motivation

https://datadoghq.atlassian.net/browse/CONTP-2154

Additional Notes

Profiles now apply explicit SSI settings even when instrumentation.enabled is omitted, instead of ignoring them:
DDA

instrumentation:
  enabled: true
  languageDetection:
    enabled: true

Profile

instrumentation:
  languageDetection:
    enabled: false

Before: profile setting ignored

instrumentation:
  enabled: true
  languageDetection:
    enabled: true

After: profile setting overrides the DDA

instrumentation:
  enabled: true
  languageDetection:
    enabled: false

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  1. Deploy operator with profiles enabled
  2. Create a dda with admission controller, apm, and ssi enabled:
 features:
   admissionController:
     enabled: true
   apm:
     enabled: true
     instrumentation:
       enabled: true
       languageDetection:
         enabled: true
  1. Create a profile with language detection disabled and apm host port 9126 enabled:
 features:
   apm:
     hostPortConfig:
       enabled: true
       hostPort: 9126
     instrumentation:
       languageDetection:
         enabled: false
  1. Check that the dap is applied: kubectl get dap <dap> -o jsonpath='{.status.applied}{"\n"}' should be true
  2. Check that language detection is disabled in default and profile ddais: kubectl get ddai <ddai> -o jsonpath='{.spec.features.apm.instrumentation.languageDetection.enabled}{"\n"}' should be false
  3. Check the host ports: kubectl get ddai -o custom-columns='NAME:.metadata.name,APM_HOST_PORT:.spec.features.apm.hostPortConfig.hostPort'. The profile DDAI should show 9126; the default DDAI should show

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@khewonc khewonc added this to the v1.32.0 milestone Oct 6, 2026
@khewonc
khewonc requested a review from a team October 6, 2026 14:52
@khewonc
khewonc requested review from a team as code owners October 6, 2026 14:52
@khewonc
khewonc requested review from pierreprinetti and removed request for a team October 6, 2026 14:52
@khewonc khewonc added the bug Something isn't working label Oct 6, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T14:57:27.230297Z a9c8914 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9c8914e97

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@khewonc
khewonc force-pushed the khewonc/fix-defaulted-profile-overlays branch from a9c8914 to 13e25ea Compare October 6, 2026 15:03
@datadog-official

datadog-official Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Pipelines  Code Coverage

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

DDCI - DataDog/datadog-operator | e2e_autoscaling

View more details · View in DDCI

DataDog/datadog-operator | e2e_autoscaling

View more details · View in GitLab

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 90.45%
• Overall Coverage: 57.73% (+0.08%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fac189c | Docs | View more details | Give us feedback!

@khewonc
khewonc force-pushed the khewonc/fix-defaulted-profile-overlays branch from 07f1a8c to f5c7022 Compare October 13, 2026 20:15
@khewonc khewonc modified the milestones: v1.32.0, v1.33.0 Oct 28, 2026
@khewonc
khewonc force-pushed the khewonc/fix-defaulted-profile-overlays branch from f5c7022 to fac189c Compare November 5, 2026 21:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant