Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9c8914e97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a9c8914 to
13e25ea
Compare
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: fac189c | Docs | View more details | Give us feedback! |
07f1a8c to
f5c7022
Compare
f5c7022 to
fac189c
Compare
What does this PR do?
Uses the user provided manifest instead of a defaulted manifest to create shared configs and dependencies for profiles and ddas. Previously, we used the defaulted manifest, so we couldn't tell if a config was set by the user or defaulted. For profile overlays, this meant we'd favor a defaulted (but unset) config over a user-set profile config
Motivation
https://datadoghq.atlassian.net/browse/CONTP-2154
Additional Notes
Profiles now apply explicit SSI settings even when
instrumentation.enabledis omitted, instead of ignoring them:DDA
Profile
Before: profile setting ignored
After: profile setting overrides the DDA
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
kubectl get dap <dap> -o jsonpath='{.status.applied}{"\n"}'should betruekubectl get ddai <ddai> -o jsonpath='{.spec.features.apm.instrumentation.languageDetection.enabled}{"\n"}'should befalsekubectl get ddai -o custom-columns='NAME:.metadata.name,APM_HOST_PORT:.spec.features.apm.hostPortConfig.hostPort'. The profile DDAI should show 9126; the default DDAI should showChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel